fix(background): Tweak logic to inject script programmatically #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes freelawproject/recap#346.
The current implementation of the extension inserts scripts listed in the
CONTENT_SCRIPT_FILES
array calling theexecuteScripts
method sequentially inside a for-loop. I think this approach is causing the bug in Firefox because theexecuteScript
is an asynchronous function, so there may be calls that are still running when the next one starts (which is not desired).We need to make sure the extension injects a new script after the previous one succeeds and so on. Luckily we can pass a callback function
executeScripts
method so we can nest theexecuteScript
calls like this:The previous code makes sure the
master.js
script is injected after thejquery.js
file and so on, but the nesting can get unwieldy so this PR adds a helper function to abstract the previous approach and handle the programmatically script injection.