fix(content_delegate): Fix zip upload in district courts #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the extractUrl helper function to retrieve the zip URL from the script tag.
Updates regex to remove invalid escape sequences and adds capturing groups to eliminate the replace method.
|
LGTM! Does this affect all zip uploads or just some of them for some reason? |
|
@mlissner I believe that all zip uploads made from a macOS device are affected. I tested the upload feature with different courts and got the same problem every time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes freelawproject/recap#352 by tweaking the
extractUrlmethod to retrieve the URL from thescripttag. During the debugging process, I noticed the absence of a message indicating that the extension was uploading the zip file. To address this, I added a loading message on the page to inform users that the extension is working on the upload task.Here's a GIF showing the new message:
Additional comments
I couldn't reproduce the issue on Windows, it seems specific to macOS.