Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional appelate attachment page detection logic #352

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

ttys0dev
Copy link
Contributor

@ttys0dev ttys0dev commented Dec 1, 2023

Seems some appellate court attachment pages aren't getting detected so lets add a fallback.

@mlissner
Copy link
Member

mlissner commented Dec 1, 2023

LGTM. Eduardo, will you merge if you think it's good?

@ERosendo
Copy link
Contributor

ERosendo commented Dec 1, 2023

@mlissner sure! @ttys0dev can you share an example of an attachment page that is not getting detected?

@ttys0dev
Copy link
Contributor Author

ttys0dev commented Dec 1, 2023

can you share an example of an attachment page that is not getting detected?

I think it was any attachment pages on ca10.

@ERosendo
Copy link
Contributor

ERosendo commented Dec 1, 2023

@ttys0dev thanks! I found an example. Here's the link:

https://ecf.ca10.uscourts.gov/n/beam/servlet/TransportRoom?servlet=ShowDoc/010010958402&caseId=87088&recapCaseNum=23-5097

We're using the form which is typically located at the bottom of the page to identify attachment pages. However, for documents exceeding a combined size of 30 MB, the form is not there.

image

Copy link
Contributor

@ERosendo ERosendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Thanks.

@ERosendo ERosendo merged commit eae1c07 into freelawproject:main Dec 1, 2023
5 checks passed
@ttys0dev ttys0dev deleted the appelate-attachment branch December 1, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants