Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setBadgeText type error #366

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix setBadgeText type error #366

merged 1 commit into from
Apr 3, 2024

Conversation

ttys0dev
Copy link
Contributor

@ttys0dev ttys0dev commented Apr 3, 2024

Fixes:

Error: Type error for parameter details (Property "text" is required) for browserAction.setBadgeText.

@ttys0dev
Fix setBadgeText type error
8fc206d 
Fixes:
Error: Type error for parameter details (Property "text" is required) for browserAction.setBadgeText.
@mlissner
Copy link
Member

mlissner commented Apr 3, 2024

@ERosendo, can you review, please?

@ERosendo
Copy link
Contributor

ERosendo commented Apr 3, 2024

LGTM, thanks @ttys0dev.

@ERosendo ERosendo merged commit fb77b32 into freelawproject:main Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
@erosendo's backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttys0dev @mlissner @ERosendo