feat(pacer): Adds new floating banner to the Login Page #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit relocates the constants containing values used to create banner variants from the options.js file to the content.js file.
ERosendo
force-pushed
the
367-feat-adds-banner-to-the-login-page
branch
from
3c1ab5b
to
e3e3c21
Compare
mlissner
requested changes
Apr 18, 2024
|
@mlissner I tweaked the code to dismiss the banner when users click the learn more button. Here's a gif to see it in action:
|
mlissner
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the latest comment from #367. It improves the user experience by relocating the banner from within the popup to a more prominent position on the PACER Login page. This change ensures the banner is clearly visible to users, promoting better awareness and interaction.
Here's a list of the key changes of this PR:
Removes the logic to display the badge and the old banner within the popup window.
The
options.htmlfile gets updated by removing all outdated HTML elements related to the old banner.A new helper method named
addRecapBannerToLoginPageis introduced. This method uses Javascript to dynamically create the new banner.Enhances the content.js file with new logic to manage the banner visibility on the PACER login page.
Here's a screenshot of the login page with the banner: