Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appellate): Adds logic to upload the Docket report from ACMS #372

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Apr 24, 2024

This PR introduces a new method handleAcmsDocket to the AppellateDelegate class specifically for handling Docket report uploads from ACMS.

Key Changes:

  • I've refactored the dispatchPageHandler method to handle both ACMS and other appellate courts. Now there are two separate methods:

    • regularAppellatePageHandler (existing) - Handles pages for all appellate courts except ACMS.

    • ACMSPageHandler (new) - Specifically designed for ACMS pages.

  • The ACMSPageHandler helper uses the path to identify the ACMS page. This differs from the regular handler which relies on the query string.

  • The handleAcmsDocket uses an observer to trigger the upload logic only when the page is fully loaded. This approach is necessary because the new ACMS docket report uses Vue.js to render data dynamically.

This PR depends on #371

@ERosendo ERosendo marked this pull request as ready for review April 24, 2024 01:17
@ERosendo ERosendo requested a review from mlissner April 24, 2024 01:17
Base automatically changed from feat-adds-acms-docket-upload-type to main April 24, 2024 16:35
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. One little thing, then, I guess, let's merge.

Thank you!

CHANGES.md Outdated Show resolved Hide resolved
@ERosendo ERosendo requested a review from mlissner April 24, 2024 19:20
@mlissner mlissner merged commit 3a2a781 into main Apr 24, 2024
8 checks passed
@mlissner mlissner deleted the feat-adds-logic-to-upload-acms-docket-report branch April 24, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants