feat(acms): Adds support to upload ACMS attachment pages #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlissner
approved these changes
May 25, 2024
src/appellate/appellate.js
Outdated
Comment on lines
91
to
93
| console.log('in cb'); | ||
| if (ok) { | ||
| console.log('cb success'); |
There was a problem hiding this comment.
Some stray logging here. Can you please remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new upload type for attachment pages from ACMS('ACMS_ATTACHMENT_PAGE': 17) and adds a new method
handleAcmsAttachmentPageto theAppellateDelegateclass specifically for handling attachment pages uploads from ACMS.This PR depends on freelawproject/courtlistener#3393.
Here's a gif showing how the extension works: