fix(pacer): Prevents error by checking filingCookie existence #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERosendo
force-pushed
the
371-adds-robust-check-to-retrieve-filing-cookie
branch
from
84a412c
to
64e104a
Compare
ERosendo
force-pushed
the
371-adds-robust-check-to-retrieve-filing-cookie
branch
from
64e104a
to
2ab8049
Compare
mlissner
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes freelawproject/recap#371 by checking the
filingCookievariable before accessing its value. I also added tests to ensure the fix works as expected and prevent regressions in the future.