-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(toolbar): Implements logic to display badge icon #379
Conversation
7b625a7
to
5edb8aa
Compare
7d9d330
to
9584f78
Compare
9584f78
to
a55d0c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but one usability thought below.
I think we'll continue refining this behavior (is it annoying to have to dismiss the news in two places?), but it's probably fine to roll with for now.
src/toolbar_button.js
Outdated
) { | ||
chrome.browserAction.setBadgeText({ text: '' }); | ||
} else { | ||
chrome.browserAction.setBadgeText({ text: '📣' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good in this PR, but on my OS, the badge was a deep red color, which made it look like an error. I also wasn't quite able to figure out what the megaphone icon was without looking really closely.
So two thoughts:
-
Can we change the background color to something that looks less like an error? Maybe blue?
-
Can we use a more common emoji? I think the 🎁 one is pretty common and what Slack uses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the background color to something that looks less like an error? Maybe blue?
We can customize the background color but I don't think we can tweak the style of the emoji. Here's an example:
Can we use a more common emoji?
I suggest using the bell emoji 🔔. I just noticed the megaphone emoji renders as a red megaphone in Gmail, but the bell emoji 🔔 works fine.
Let me know what you think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Let's to browsers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'll update the emoji
@mlissner I've updated the emoji |
This pull request introduces several enhancements to the user interface:
These changes provide greater flexibility and control for users:
Here are screenshots showing the banners:
Here's a gif showing how the "learn more" button works:
This GIF demonstrates how users can hide a banner without losing access to the other: