Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): Implements logic to display badge icon #379

Merged
merged 8 commits into from
Jul 12, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Jul 12, 2024

This pull request introduces several enhancements to the user interface:

  • A new banner is added to the options page, complementing the existing banner on the login page.
  • A badge is incorporated into the extension icon for improved visibility.

These changes provide greater flexibility and control for users:

  • The close buttons on each banner operate independently, preventing accidental dismissals.
  • The "Learn More" button offers a convenient way to remove both banners simultaneously.

Here are screenshots showing the banners:

image

image

Here's a gif showing how the "learn more" button works:

Screen Recording 2024-07-12 at 11 30 25 AM

This GIF demonstrates how users can hide a banner without losing access to the other:

Screen Recording 2024-07-12 at 11 43 15 AM

@ERosendo ERosendo added the no changelog Override Check Changelog Action. label Jul 12, 2024
@ERosendo ERosendo force-pushed the feat-adds-banner-to-the-options-page branch from 7b625a7 to 5edb8aa Compare July 12, 2024 13:57
@ERosendo ERosendo force-pushed the feat-adds-banner-to-the-options-page branch from 7d9d330 to 9584f78 Compare July 12, 2024 14:46
@ERosendo ERosendo force-pushed the feat-adds-banner-to-the-options-page branch from 9584f78 to a55d0c1 Compare July 12, 2024 15:29
@ERosendo ERosendo removed the no changelog Override Check Changelog Action. label Jul 12, 2024
@ERosendo ERosendo marked this pull request as ready for review July 12, 2024 16:12
@ERosendo ERosendo requested a review from mlissner July 12, 2024 16:12
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one usability thought below.

I think we'll continue refining this behavior (is it annoying to have to dismiss the news in two places?), but it's probably fine to roll with for now.

) {
chrome.browserAction.setBadgeText({ text: '' });
} else {
chrome.browserAction.setBadgeText({ text: '📣' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good in this PR, but on my OS, the badge was a deep red color, which made it look like an error. I also wasn't quite able to figure out what the megaphone icon was without looking really closely.

So two thoughts:

  1. Can we change the background color to something that looks less like an error? Maybe blue?

  2. Can we use a more common emoji? I think the 🎁 one is pretty common and what Slack uses?

Copy link
Contributor Author

@ERosendo ERosendo Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the background color to something that looks less like an error? Maybe blue?

We can customize the background color but I don't think we can tweak the style of the emoji. Here's an example:

image

image

Can we use a more common emoji?

I suggest using the bell emoji 🔔. I just noticed the megaphone emoji renders as a red megaphone in Gmail, but the bell emoji 🔔 works fine.

image

Let me know what you think

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Let's :shipit: to browsers!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'll update the emoji

@ERosendo
Copy link
Contributor Author

@mlissner I've updated the emoji :shipit:

@mlissner mlissner merged commit 1cfc4ad into main Jul 12, 2024
8 checks passed
@mlissner mlissner deleted the feat-adds-banner-to-the-options-page branch July 12, 2024 19:00
@ERosendo ERosendo changed the title feat(toolbar): Implements logic to display gift badge icon feat(toolbar): Implements logic to display badge icon Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants