feat(pacer): Enhance isLoginPage to accurately identify login pages #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refines the isLoginPage helper function to correctly detect both the standard and manage account login pages. It achieves this by employing a more specific URL path-based approach.
mlissner
approved these changes
Jul 16, 2024
|
Great, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging freelawproject/recap#373, I noticed pacer has 2 different login pages. One for the manage account page and another one to access pacer. Here are the URLs:
https://pacer.login.uscourts.gov/csologin/login.jsf
https://pacer.psc.uscourts.gov/pscof/login.xhtml
This PR refines the
isLoginPagehelper function to correctly detect both the standard and manage account login pages. It achieves this by employing a more specific approach checking the path.After merging this PR, the extension will insert the banner in both login pages:
Also, this PR fixes freelawproject/recap#373