feat(build): Adds automated release package creation script #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERosendo
added
no changelog
ERosendo
force-pushed
the
feat-add-script-to-create-release-packages
branch
from
90f34cd
to
807d22d
Compare
ERosendo
force-pushed
the
feat-add-script-to-create-release-packages
branch
from
807d22d
to
e92ac27
Compare
mlissner
approved these changes
Aug 27, 2024
scripts/build.sh
Outdated
| mkdir -p build/release/ | ||
|
|
||
| # 4. Clean up any existing release zip | ||
| rm -f build/release/$browserType-release.zip |
There was a problem hiding this comment.
Do you need to force this? Scary stuff.
There was a problem hiding this comment.
Do you need to force this?
Not really, I used the -f flag to suppress the exit code when the file couldn't be found. However, I've modified the command to handle missing files differently. Thanks for your comment.
mlissner
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new script,
build.sh, to address inconsistencies in how Chrome and Firefox handle thefavicon_urlkey within thesearch_providerobject. This script automates the creation of release packages specific to each browser.Key changes:
Ensures consistent behavior across Chrome and Firefox by addressing the
favicon_urlinconsistency.Introduces two new commands in
package.json:npm run release-chrome: Creates a Chrome-compatible release package within a dedicated build folder.npm run release-firefox: Creates a Firefox-compatible release package within the same build folder.Removes the manual creation of
zipfiles, streamlining the release process.Updates the
README.mdfile to reflect new build steps