fix(safari): Resolve manifest upgrade compatibility issues #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity This commit prevents the extension from triggering notifications in Safari, as the browser doesn't support the necessary API methods(`notifications.create`).
mlissner
approved these changes
Aug 30, 2024
|
Ugh. We used to ask people to install a special notification tool on Apple computers to do notifications, because the OS hadn't figured them out yet. I guess a solution here could be to use the website's notification system, assuming Safari supports that. Seems like it can wait, but I guess it's a solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues:
Updates the script that creates the MacOS and iOS version of the extension: After updating the manifest file to include new API permissions, the
update_manifest_fileshelper method was overwriting the existing permissions for the macOS and iOS versions of the extension with a hardcoded list(This caused compatibility issues). The PR removes the hardcoded permissions list from the helper method, ensuring that the same set of permissions is used across all browsers.While testing the extension, I noticed that the code that creates notifications was consistently raising exceptions. Investigating the Notifications API documentation , I realized Safari currently doesn't support this functionality. To prevent these errors and ensure a smooth user experience across browsers, I implemented an early return mechanism within the
showNotificationfunction. This return now occurs specifically when the extension detects it's running in Safari.