feat(background): Adds logic to clean up storage after upload #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERosendo
force-pushed
the
feat-clean-up-local-storage-after-upload
branch
from
4c6abee
to
80e8f0e
Compare
mlissner
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During QA testing for the upcoming extension release, I noticed that temporary upload data (files and zips) was not being removed from local storage after successful uploads. This issue could potentially lead to unnecessary storage usage and performance concerns.
This PR addresses the problem by tweaking the
triggerFetchRequestmethod inbackground_fetch.js. The changes ensure that temporary data is consistently deleted from local storage once the upload process is complete.