forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-8357 - Release-5.17.0 #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id#7216) * Handling banner+video mediaTypes in adUnit configuration. * SIM-1146 CSync only if not null, test added. * Fixing an issue of undefined videoParams * Fixing an issue with video startdelay got crushed * Fixing indenting issues and startdelay * Fixed a bunch of tests * Fixing a test for IE11 not okay with find method * Added multi mediatype to .md file Co-authored-by: tadam75 <tadam@smartadserver.com>
* SADR-2305 Add support for floors module * SADR-2305 Add unit test for unknown currency * lint fix
* OpenX Bid Adapter: read fpd data from ortb2.user.data for permutive * OpenX Bid Adapter: read liveintent segments from request * OpenX Bid Adapter: read segtax * OpenX Bid Adapter: fix IE11 Object.entries() unsupported issue addresses prebid#7202 (comment)
* Support new aniview bid adapter * Support new aniview bid adapter * Support new aniview bid adapter * Support new aniview bid adapter * Fix Consent parameters * Update aniviewBidAdapter.js V3 support * Update aniviewBidAdapter.js * Update aniviewBidAdapter.js Update refererInfo * Update aniviewBidAdapter.js Fix tabs and spaces * Update aniviewBidAdapter.js fixes * Update aniviewBidAdapter.js * Update aniviewBidAdapter.js Add ccpa support * Update aniviewBidAdapter.js Typo * Update aniviewBidAdapter.js * Update aniviewBidAdapter.js * Fix size and sample Fixed sizes from playerSize Updated md sample * Fix tabs * Fix sizes * Recheck * Add tgt parameter * Update sample * Add support for cookie sync + tests * Add support for cookie sync + tests * Add support for cookie sync + tests * Support aliases Support aliases * Update Update * Fix lint Fix lint * Update spec Update spec * Aniview Bid Adapter: Added the new alias * Aniview Bid Adapter: Added the new configs for the renderer * Aniview Bid Adapter: Added unit tests for the renderer * Aniview Bid Adapter: Have added gvlid * Aniview Bid Adapter: added meta.advertiserDomains to bidResponse and extended cookie sync logic * Support BANNER mediaType Support BANNER mediaType * Aniview BANNER support Fix spaces * Aniview Bid Adapter: add a new alias and update the doc Co-authored-by: Itay Nave <itay@aniview.com> Co-authored-by: Itay Nave <38345760+itaynave@users.noreply.github.com>
…o params support (prebid#7263) * initial * fix * remove redundant language mod, use player sizes in video traff * test modify * fix * Adding Tests * add keywords param * log * log * log * fix * add idl * add idl * fix test * lint * lint * fix * lint * lint * lint * lint * add sync * fix * add video params, advertiserDomains and getFloor * add audiences param * fix test Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com> Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
* initial * change vasturl to vastxml * fixes Co-authored-by: Aiholkin <artem.iholkin@smartyads.com> Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com>
* added Brave bidder adapter with test and docs Commit has standard bidder adapter 2 new files adapter js, adapter md * added test spec file witch covered code least 80 %
Changed directory path in the line #115 from url: `${hostname}/auc/auc.php` to ${hostname}/
Co-authored-by: atkachov <atkachov@admixer.ua>
* inital * fix * fix * fix * fix * fix * fix * add maintener to md * Added native support * add syncing * updates for prebid 5 compliance Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
* add contentexchange bid adapter * fixes * fix * fix test * validate meta * fix
…ithout ad server dependancies (prebid#7151) * Add bidViewablityIO module - Emits a BID_VIEWABLE event for banner ads when a bid meets IAB viewable specifications, using the browsers IntersectionObserver API, if it is available - adds the new module, markdown documentation, an integration example, and tests * fix issues in integration example and tests * only register the event handler if the module is configured * fix config example in markdown * use getConfig's subscribe functionality * use indexOf instead of includes * wrap logMessage to prefix MODULE_NAME on messages
* Add back in sharedid prebid#7221 * fix linting * add tests for sharedid * remove trailing spaces
…er (for out-stream) then continue w/o video (prebid#7275) * Bug fix to still bid banner and/or native when no outstream renderer is available
* InteractiveOffers BidAdapter: New endpoint * InteractiveOffers - Parameters changed & dynamic endpoint * InteractiveOffers - Fix lint errors * InteractiveOffers - Change the spec file * InteractiveOffers - Fix spec file Co-authored-by: EC2 Default User <ec2-user@ip-172-31-93-198.ec2.internal>
* Mediakeys: add bidder adapter * Removed superfluous argument Co-authored-by: Jean-Paul COSAL <jean-paul.cosal@mediakeys.com>
…bid#7239) * add imuidIdSystem * add test and refactoring imuid module
* added cpmstarBidAdapter with meta.advertiserDomains support * fix linting Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
…7160) Documentation[1] shows a numeric example which causes an exception as we try to call .split(','). [1] https://docs.prebid.org/dev-docs/add-rtd-submodule.html#gettargetingdata
…sample_rate cookie expiration (prebid#7462) * ATS-analytics-adapter - increase sampling rate cookie expiration time, handle error on preflight request * ATS-analytics-adapter - increase adapter version to 2 * ATS-analytics-adapter - fix logs * ATS-analytics-adapter - add unit tests * ATS-analytics-adapter - code improvements, add more unit tests
Co-authored-by: marc_tappx <marc@tappx.com>
* Added TheMediaGridNM Bid Adapter * Updated required params for TheMediaGridNM Bid Adapter * Update TheMediGridNM Bid Adapter * Fix tests for TheMediaGridNM Bid Adapter * Fixes after review for TheMediaGridNM Bid Adapter * Add support of multi-format in TheMediaGrid Bid Adapter * Update sync url for grid and gridNM Bid Adapters * TheMediaGrid Bid Adapter: added keywords adUnit parameter * Update TheMediaGrid Bid Adapter to support keywords from config * Implement new request format for TheMediaGrid Bid Adapter * Fix jwpseg params for TheMediaGrid Bid Adapter * Update unit tests for The Media Grid Bid Adapter * Fix typo in TheMediaGrid Bid Adapter * Added test for jwTargeting in TheMediaGrid Bid Adapter * The new request format was made by default in TheMediaGrid Bid Adapter * Update userId format in ad request for TheMediaGrid Bid Adapter * Added bidFloor parameter for TheMediaGrid Bid Adapter * Fix for review TheMediaGrid Bid Adapter * Support floorModule in TheMediaGrid Bid Adapter * Fix empty bidfloor for TheMediaGrid Bid Adapter * Some change to restart autotests * Fix userIds format for TheMediaGrid Bid Adapter * Remove digitrust userId from TheMediaGrid Bid Adapter * Protocols was added in video section in ad request for TheMediaGrid Bid Adapter * TheMediaGrid: fix trouble with alias using * TheMediaGridNM: fix trouble with alias * TheMediaGrid Bid Adapter: added support of PBAdSlot module * TheMediaGrid Bid Adapter: fix typo * GridNM Bid Adapter: use absent in params data from mediaTypes * GridNM Bid Adapter: fix md file + add advertiserDomains support * TheMediaGrid and gridNM Bid Adapter: minor netRevenue fixes * gridNM Bid Adapter updates after review * TheMediaGrid Bid Adapter: fix keywords workflow * fix testing and kick off lgtm again * TheMediaGrid: added ext.bidder.grid.demandSource processing * TheMediaGrid: added user.id from fpd cookie * TheMediaGrid: control cookie setting via bidder config * TheMediaGrid: use localStorage instead cookie * TheMediaGridNM Bid Adapter: update adapter to use /hbjson endpoint * TheMediaGridNM: fix unnecessary conditions * TheMediaGrid: fix bug with nurl field in response * TheMediaGrid: update test * TheMediaGridNM: fix possible bug with nurl Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
…t coverage updates (prebid#7447) * Update tests for sspBC adapter Update tests for sspBC adapter: - change userSync test (due to tcf param appended in v4.6) - add tests for onBidWon and onTimeout * [sspbc-adapter] RC for 5.2 version of sspBCBidAdapter * [sspbc-adapter] RC for 5.2 version of sspBCBidAdapter(fixed commit) Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
* Add trustx adapter and tests for it * update integration example * Update trustx adapter * Post-review fixes of Trustx adapter * Code improvement for trustx adapter: changed default price type from gross to net * Update TrustX adapter to support the 1.0 version * Make requested changes for TrustX adapter * Updated markdown file for TrustX adapter * Fix TrustX adapter and spec file * Update TrustX adapter: r parameter was added to ad request as cache buster * Add support of gdpr to Trustx Bid Adapter * Add wtimeout to ad request params for TrustX Bid Adapter * TrustX Bid Adapter: remove last ampersand in the ad request * Update TrustX Bid Adapter to support identical uids in parameters * Update TrustX Bid Adapter to ignore bids that sizes do not match the size of the request * Update TrustX Bid Adapter to support instream and outstream video * Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter * Update TrustX Bid Adapter to use refererInfo instead depricated function utils.getTopWindowUrl * HOTFIX for referrer encodind in TrustX Bid Adapter * Fix test for TrustX Bid Adapter * TrustX Bid Adapter: added keywords passing support * TrustX Bid Adapter: added us_privacy parameter in bid request * TrustX Bid Adapter: fix us_privacy parameter in bid request * Fix alias error for TrustX Bid Adapter * TrustX Bid Adapter: added new request format * TrustX Bid adapter: fix new format endpoint * TrustX Bid Adapter: update md file to support useNewFormat parameter * TrustX Bid Adapter: added additional sync url * TrustX Bid Adapter: added check for enabled syncs number + added gdpr data to sync urls * TrustX Bid Adapter: added support of meta.advertiserDomains * TrustX Bid Adapter: added support rtd permutive and jwplayer for new and old request format * TrustX Bid Adapter: Use new format by default + new keywords logic * TrustX Bid Adapter: fix md file * TrustX: Convert all id-like request fields to a string * TrustX: added vastUrl support
- Capture network ids and GDPR consent choice - Retrieve and set vault JWT - Increase code coverage - General refactor / tidy
…7534) Co-authored-by: Sasan Farrokh <sasan.farrokh@vidoomy.com>
…TTP request per impression (prebid#7509) * Ensure that a separate openRTB request object is created for each bid request. Each request will have one imp object in the array for the imp field. * Cleanup specs for Sharethrough adapter and ensure that mediaType is set from the request data (impression object) instead of passing all bid request data through to the adserver. Co-authored-by: Josh Becker <jbecker@sharethrough.com> Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Increment version of sharethrough adapter to v4.0.1 from v4.0.0 Co-authored-by: Josh Becker <jbecker@sharethrough.com> Co-authored-by: Eddy Pechuzal <epechuzal@sharethrough.com> * Remove unnecessary strData attribute * Remove extra newline Co-authored-by: Josh Becker <jbecker@sharethrough.com>
* KRAK-3001 adding video support to prebid adapter * Simplified video implementation * Linting * Removed video context validation * Revert merge bidIDs->bidIds * Updated placement ID for video test Co-authored-by: fionasequeira <fiona.sequeira891@gmail.com>
* Enable supplyChain support * Added support for COPPA * rebuilt * Added support for Extended User IDs. * Added support for the "meta" attribute in bid response. * Added support for config.ortb2. * Delete nobidBidAdapter.js.orig * Delete .project * Delete .jsdtscope * Delete org.eclipse.wst.jsdt.ui.superType.container * Delete org.eclipse.wst.jsdt.ui.superType.name * Delete a * Tests for "ortb2" support. Co-authored-by: Reda Guermas <reda.guermas@nobid.io>
* Recover nextroll module This reverts commit 412277f. * Update NextRoll BidAdapter for v5 * Use individual imports for utils module
* Adnuntius Bid Adapter: Added tests for gdpr and segments * Changed bidder to read segments from ortb2. * Adding deals to response.
nicgallardo
requested review from
aecook,
agrecoFS,
Barteezy,
ialex and
premesh-freestar
October 7, 2021 17:24
aecook
approved these changes
Oct 7, 2021
agrecoFS
approved these changes
Oct 7, 2021
ialex
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to keep pace with the PBJS release version, we must upgrade to PBJS 5.13.0.
Requirements
Merge down from remote origin Prebid current stable tag (5.13.0)