Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow technical committee members to veto external proposals #774

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

luispdm
Copy link
Contributor

@luispdm luispdm commented Sep 12, 2024

  • pallet_membership has been added: not only it enables technical committee members to veto, it also adds the ability to add, remove, swap and set members of any collective (council and technical committee in our case). Use this pallet to manage members of a collective
  • any type of external proposal can be vetoed (whether super majority approves, against or simple majority)
  • once a proposal has been vetoed, it cannot be resubmitted during the cooloff period in the form of public proposal or external proposal with super majority approves. However, during the cooloff period, the same proposal can be resubmitted via super majority against or simple majority voting system
  • technical committee members must be set only via the technicalCommitteeMembership pallet, as those changes will propagate to the technicalCommittee collective pallet. The other way around is not true. In other words: if a member is added via the technicalCommittee collective pallet, they will not be part of the technicalCommitteeMembership pallet, meaning that their veto won't be allowed as the origin is violated

@luispdm luispdm marked this pull request as ready for review September 17, 2024 14:38
@luispdm luispdm linked an issue Sep 17, 2024 that may be closed by this pull request
…ion (#783)

* removed the memebership for Council

* council can't setMemebers of the Technical commeteed

* fix benchmark compilation
@asiniscalchi asiniscalchi merged commit 212d343 into main Sep 19, 2024
8 checks passed
@asiniscalchi asiniscalchi deleted the feature/tech-committee-veto branch September 19, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech committee must be able to veto
2 participants