Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big borders around alphanumerics #456

Open
tommkell opened this issue Jan 2, 2024 · 11 comments
Open

Big borders around alphanumerics #456

tommkell opened this issue Jan 2, 2024 · 11 comments

Comments

@tommkell
Copy link

tommkell commented Jan 2, 2024

When using the punch feature of b2s, the alphanumeric displays punch out a bigger area than needed. The only way around this is to make the alphanumerics much smaller + doesn't look great. Would it be possible to reduce the size of the borders around them? Thank you

@buffdriver
Copy link
Contributor

I've done so in my branch of Freezy's repository. I think the best would be to allow the properties LinePaddingPercentage and OuterPaddingPercentage to be set in the configuration editor. With my meager skills :) I will work on this and perhaps propose a merge at some later date. For now, you are welcome to pull my source for RasterizeDimensions.cs and recompile.

@tommkell
Copy link
Author

tommkell commented Jan 3, 2024

@buffdriver I've no idea how to do that! Can you explain it?

@buffdriver
Copy link
Contributor

buffdriver commented Jan 3, 2024

Sorry, it was a bit presumptuous of me to have you recompile the source. Go [here] and download the zip file. Unzip and save the three binaries in the appropriate folder. Be sure to backup first.

@tommkell
Copy link
Author

tommkell commented Jan 3, 2024

Thanks for this @buffdriver, you're a legend 🙂

@freezy
Copy link
Owner

freezy commented Apr 21, 2024

@buffdriver Interested in getting this back upstream? :)

@buffdriver
Copy link
Contributor

buffdriver commented Apr 21, 2024

@freezy I wish I could say I've done something other than change the hard-coded values for padding. It's all of about two lines of code. If you feel the new values are better, I would be happy to push. It has remained useful to me.

@freezy
Copy link
Owner

freezy commented Apr 22, 2024

Maybe make it configurable? That would be the best option.

@buffdriver
Copy link
Contributor

buffdriver commented Apr 22, 2024 via email

@SmedleyB
Copy link

I would really appreciate the configurability. I'd also suggest, like the original comment, that the default border/padding around the alphanumerics becomes a lot smaller as the size of the visible part of the display is almost universal across machines. The current amount of padding is way too big.

@buffdriver
Copy link
Contributor

buffdriver commented Apr 24, 2024 via email

@buffdriver
Copy link
Contributor

buffdriver commented Apr 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants