add ShellCheck Linter #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akira25
added a commit
that referenced
this pull request
Aug 29, 2022
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Aug 29, 2022
semver.sh is not our own library. We shouldn't check it therfore. This precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
|
Is this PR still needed? |
Akira25
added a commit
that referenced
this pull request
Feb 6, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Feb 6, 2023
semver.sh is not our own library. We shouldn't check it therfore. This precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
|
This PR follows on #329. That PR fixes several issues pointed out by shellcheck. Afterwards, we can activate the shellcheck-linter, which is done by this PR. |
Akira25
added a commit
that referenced
this pull request
Feb 6, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Feb 6, 2023
semver.sh is not our own library. We shouldn't check it therfore. This precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
|
I created #356 as a better approach to address the ShellCheck issues in smaller chunks that are easier to review. |
Akira25
added a commit
that referenced
this pull request
Jun 11, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Jun 11, 2023
semver.sh is not our own library. We shouldn't check it therfore. This precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Jun 11, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Jun 11, 2023
semver.sh is not our own library. We shouldn't check it therfore. This precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Jul 24, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Jul 24, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Sep 22, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Oct 7, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Oct 8, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Akira25
added a commit
that referenced
this pull request
Nov 19, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
pktpls
pushed a commit
that referenced
this pull request
Nov 22, 2023
This commit fixes some shellcheck issues in the mentioned script. It precedes #315. Signed-off-by: Martin Hübner <martin.hubner@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo needs some work before this pull request could be merged.