-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up packages #384
Clean up packages #384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I would have preferred to keep the routing-daemon-stuff in a separate package, but it's perfectly fine to do it in this way too.
@pktpls before merging, we should fix the liniting errors too. |
I'm on it. |
.github/workflows/linter.yml
Outdated
@@ -58,3 +58,4 @@ jobs: | |||
# Change to 'master' if your main branch differs | |||
DEFAULT_BRANCH: master | |||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
FILTER_REGEX_EXCLUDE: "*/usr/bin/hna.lua*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*/usr/bin/hna.lua*
=> .*/usr/bin/hna\.lua.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved in current version. I ommited the one \
though. codium complained, that the backslash would result in invalid YAML-Syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case you could write it as [.]
or try using double escaping \\.
as otherwise the .
matches any single character except for line terminators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected again. :) Lets see, if the CI takes this.
b963f15
to
ab177d4
Compare
Okay, that works too. Lets merge this. The failing build-pipeline is due to OpenWrt changed their dockerized SDK. |
Signed-off-by: Packet Please <pktpls@systemli.org>
Signed-off-by: Packet Please <pktpls@systemli.org>
Signed-off-by: Packet Please <pktpls@systemli.org>
Signed-off-by: Packet Please <pktpls@systemli.org>
Signed-off-by: Packet Please <pktpls@systemli.org>
exclude hna.lua from linter. Signed-off-by: Martin Hübner <martin.hubner@web.de>
I am merging this now, because I want to integrate some changes from #328 on this too. Its way easier to do, when this is there first. Please feel free to make a node, if there is something left you'd like to have changed. |
cherry-picked |
Maintainer: unclear
Compile tested: x86_64 aarch64_generic
Run tested: not yet
Description:
This cleans up our packages a little. My motivation is that I noticed it's really hard for me to build a mental picture of everything that's going on with all these packages. My guess is that the original intent was modularity, but right now it doesn't gain us anything and only makes our lives harder. It might be a major factor contributing to the slowdown in firmware dev activity.
Remaining questions: