Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path based redirect #19

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Add path based redirect #19

merged 1 commit into from
Nov 1, 2023

Conversation

noxilixon
Copy link
Contributor

Added a shorter path based redirect to knoteninfo. Before you needed to type e.g. https://util.berlin.freifunk.net/knoteninfo?knoten=linie206-core&typ=wiki to get a redirect to the wiki based on the node name. Now you can use ff.berlin/d/linie206-core. These are two improvements:

  1. Links are shorter. That way they can even be written on a device for documentation (see ff-sticker).
  2. Links are more generic. We don't write which service exactly we want (e.g. wiki for documentation) but say that we want the documentation of the node. Then you will be redirected to the service we currently use for it. Making it easy to migrate to an other service in the future.
d (documentation) -> wiki
m (map) -> hopglass
s (statistics) -> monitor

@noxilixon
Copy link
Contributor Author

I did not work with php and apache before. Used a lot of online help. Please give feedback and review carefully.

@noxilixon noxilixon force-pushed the short-redirect branch 3 times, most recently from 4098ce5 to 9f0145b Compare October 10, 2023 14:00
@noxilixon noxilixon removed the request for review from nicolasberens October 10, 2023 14:01
@noxilixon
Copy link
Contributor Author

Linting is failing. Mostly because of the old code. I think there is a little rewrite needed. I could do it, but maybe its easier for other people. Or we ignore it.

@nicolasberens nicolasberens merged commit 8a584f6 into master Nov 1, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants