Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alfred: upgrade package to latest release 2019.2 #1760

Closed
wants to merge 1 commit into from

Conversation

T-X
Copy link
Contributor

@T-X T-X commented Jun 19, 2019

This upgrades alfred to v2019.2.

It does not fix the deprecation warnings in dmesg triggered by batadv-vis yet (also see #1756). But I opened a ticket for now for that at open-mesh.org.

@neocturne
Copy link
Member

I don't think this is important for Gluon v2019.1, and we should consider dropping gluon-alfred after that.

@rotanid
Copy link
Member

rotanid commented Jun 19, 2019

@NeoRaider does "not important" mean that it shouldnt be merged?

@T-X
Copy link
Contributor Author

T-X commented Jun 19, 2019

@NeoRaider: Yes, you are right, it's not important. There is also pretty much no functional difference, the changes to alfred are all cosmetic.

My thinking was to stay consistent with the versions of batman-adv/batctl/alfred for the matter of form. And to avoid potential confusion (e.g. someone looking at "alfred -v" and then out of habit thinking he/she would be running batman-adv v2018.x or something stupid like that).

Does that make sense?

@neocturne
Copy link
Member

Running "alfred -v" to find out the batadv version would be quite creative ;) I don't even think there are many sites left that still use alfred, considering the packet size issues it had when respondd was created...

I'd like to avoid adding patches to Gluon that we don't need, so I'm closing this.

@neocturne neocturne closed this Jun 19, 2019
@T-X
Copy link
Contributor Author

T-X commented Jun 19, 2019

Oki doki, but thanks for your consideration :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants