Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-core: fix missing ifname for mesh_radio networks in uci #2598

Closed

Conversation

lemoer
Copy link
Member

@lemoer lemoer commented Aug 7, 2022

Before this comit, the networks in /etc/config/network looked like this:

config interface 'mesh_radio0'
    	option proto 'gluon_mesh'

After this patch, the networks look like this:

config interface 'mesh_radio0'
        option proto 'gluon_mesh'
    	option ifname 'mesh0'

Especially, this fixes a regression bug, that the "wifi" section in the
respondd request type "neighbours" was empty:

~# gluon-neighbour-info -d ::1 -r neighbours | ffh_pretty_json
{
  "wifi": [
  ],
  ...
}

After this commit, the section (correctly) looks like this:

root@UFU-FWH-A272-Tresckowstr-GemR-vorne:~# gluon-neighbour-info -d ::1 -r neighbours | ffh_pretty_json
{
  "wifi": {
    "ca:38:7e:42:5f:21": {
      "neighbours": {
        "fe:9f:4d:01:ea:e1": {
          "noise": -102,
          "inactive": 50,
          "signal": -84
        },
        "fe:df:b9:84:37:51": {
          "noise": -102,
          "inactive": 20,
          "signal": -73
        }
      }
    }
  },
  ...
}

The corresponding code can be found here: https://github.com/freifunk-gluon/gluon/blob/master/package/gluon-respondd/src/respondd-neighbours.c#L99-L101

Before this comit, the networks in /etc/config/network looked like this:

	config interface 'mesh_radio0'
        	option proto 'gluon_mesh'

After this patch, the networks look like this:

	config interface 'mesh_radio0'
	        option proto 'gluon_mesh'
        	option ifname 'mesh0'

Especially, this fixes a regression bug, that the "wifi" section in the
respondd request type "neighbours" was empty:

	~# gluon-neighbour-info -d ::1 -r neighbours | ffh_pretty_json
	{
	  "wifi": [
	  ],
	  ...
	}

After this commit, the section (correctly) looks like this:

	root@UFU-FWH-A272-Tresckowstr-GemR-vorne:~# gluon-neighbour-info -d ::1 -r neighbours | ffh_pretty_json
	{
	  "wifi": {
	    "ca:38:7e:42:5f:21": {
	      "neighbours": {
	        "fe:9f:4d:01:ea:e1": {
	          "noise": -102,
	          "inactive": 50,
	          "signal": -84
	        },
	        "fe:df:b9:84:37:51": {
	          "noise": -102,
	          "inactive": 20,
	          "signal": -73
	        }
	      }
	    }
	  },
	  ...
	}
@github-actions github-actions bot added the 3. topic: package Topic: Gluon Packages label Aug 7, 2022
@lemoer
Copy link
Member Author

lemoer commented Aug 7, 2022

I found the commit, that originally introduced this regression:

0f1fa24#diff-727ba88a65d0c44d3295d11b2dc2a04bd341ab16a978f4c1af6a3b09140921fd

@lemoer
Copy link
Member Author

lemoer commented Aug 7, 2022

I think, this PR is patching the wrong side of this issue.

@lemoer
Copy link
Member Author

lemoer commented Aug 7, 2022

Closed in favor of #2599 .

@lemoer lemoer closed this Aug 7, 2022
@lemoer lemoer deleted the pr_fix_mesh_radio_ifname_property branch February 17, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: package Topic: Gluon Packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant