Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ath79-generic: Fix autoupdater for Loco M XW from v2021.1.x to v2022.1.x #2664

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

goligo
Copy link
Contributor

@goligo goligo commented Oct 11, 2022

Ubiquiti Nanostation Loco M XW was renamed in v2022.1.x, but the alias to the old name was missing, so devices running the old release did not update.

Fixes #2663

@github-actions github-actions bot added the 3. topic: hardware Topic: Hardware Support label Oct 11, 2022
@goligo goligo changed the title FIx autoupdater for Loco M XW from v2021.1.x to v2022.1.x Fix autoupdater for Loco M XW from v2021.1.x to v2022.1.x Oct 11, 2022
@goligo goligo changed the title Fix autoupdater for Loco M XW from v2021.1.x to v2022.1.x ath79-generic: Fix autoupdater for Loco M XW from v2021.1.x to v2022.1.x Oct 11, 2022
@herbetom
Copy link
Contributor

I think convention would be to prefix your commit message with ath79-generic: like you did in the title.

Ubiquiti Nanostation Loco M XW was renamed in v2022.1.x, but the alias to the old name was missing, so devices running the old release did not update.
@rotanid
Copy link
Member

rotanid commented Oct 11, 2022

i doesn't look right to me to have three aliases to update from OpenWrt 19.07
my guess(!) is, that some of them are not necessary.

@goligo
Copy link
Contributor Author

goligo commented Oct 11, 2022

As I understand, the two more explicit ones have been introduced for the firmware selector.

@blocktrron blocktrron added the backport v2022.1.x Backport this pull request to v2022.1.x label Oct 11, 2022
@herbetom
Copy link
Contributor

As discussed at the meetup the alias are only for the manifest and not symlinks for the firmware selector.
Instead it seems to be so that there were in the past two diffrent firmwares which ran on those devices and it's possible that devices will have two diffrent identifiers depending on which firmware was originally used.

@blocktrron blocktrron merged commit d3a220d into freifunk-gluon:master Oct 11, 2022
@github-actions
Copy link

Successfully created backport PR #2667 for v2022.1.x.

JayBraker pushed a commit to JayBraker/gluon that referenced this pull request Apr 12, 2023
…1.x (freifunk-gluon#2664)

Ubiquiti Nanostation Loco M XW was renamed in v2022.1.x, but the alias to the old name was missing, so devices running the old release did not update.
@AiyionPrime AiyionPrime mentioned this pull request Apr 18, 2023
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: hardware Topic: Hardware Support backport v2022.1.x Backport this pull request to v2022.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2022.1: Autoupdater from old release does not work for Loco M XW
4 participants