Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated variable names to be more meaningful #62

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Updated variable names to be more meaningful #62

merged 1 commit into from
Oct 25, 2023

Conversation

MyIgel
Copy link
Member

@MyIgel MyIgel commented Oct 25, 2023

Description

Renamed variables in functions to convey some meaning as d (which may stand for data?) is pretty much useless when trying to understand any code flow.

Motivation and Context

Make meshviewer better useable

How Has This Been Tested?

Local dev env

Screenshots/links:

Checklist:

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

@MyIgel MyIgel added enhancement New feature or request javascript Pull requests that update Javascript code labels Oct 25, 2023
@skorpy2009
Copy link
Member

Works for me

@skorpy2009 skorpy2009 merged commit 17cad66 into main Oct 25, 2023
1 check passed
@skorpy2009 skorpy2009 deleted the variable-naming branch October 25, 2023 17:58
@MyIgel MyIgel mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skorpy2009 skorpy2009 skorpy2009 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MyIgel @skorpy2009