Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: golang linter (io package) #546

Merged
merged 2 commits into from
Jan 2, 2024
Merged

fix: golang linter (io package) #546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72198d1
fix: ioutil is now io package
GoliathLabs Jan 2, 2024
b9930ff
fix: use os instead
GoliathLabs Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cmd/serve/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package serve
import (
"context"
"fmt"
"io/ioutil"
"net"
"net/http"
"net/netip"
Expand Down Expand Up @@ -302,7 +301,7 @@ func (cmd *servecmd) Run() {
// ReadConfig reads the config file from disk if specified and overrides any env vars or cmdline options
func (cmd *servecmd) ReadConfig() *config.AppConfig {
if cmd.ConfigFilePath != "" {
if b, err := ioutil.ReadFile(cmd.ConfigFilePath); err == nil {
if b, err := os.ReadFile(cmd.ConfigFilePath); err == nil {
if err := yaml.Unmarshal(b, &cmd.AppConfig); err != nil {
logrus.Fatal(errors.Wrap(err, "failed to bind configuration file"))
}
Expand Down