feat: Add allowLongAppNames to support longer application names

This introduces the helm parameter `cd.allowLongAppNames`. When true, kuberpult accepts app names longer than 39, but maximum 70 characters.
This requires some configuration in Argo CD to work.
See #1183 for how to enable it in Argo CD.

Closes issue #1182

This was implemented by @jdvgh
In order to get this through our CI, I had to create this new PR.
Old PR: #1183

charts/kuberpult/templates/cd-service.yaml

@@ -193,6 +193,8 @@ spec:
           value: "{{ .Values.datadogProfiling.enabled }}"
         - name: KUBERPULT_MAXIMUM_QUEUE_SIZE
           value: "{{ .Values.cd.backendConfig.queueSize }}"
+        - name: KUBERPULT_ALLOW_LONG_APP_NAMES
+          value: "{{ .Values.cd.allowLongAppNames }}"
         volumeMounts:
         - name: repository
           mountPath: /repository

charts/kuberpult/values.yaml

@@ -67,6 +67,12 @@ log:
   level: "WARN"
 cd:
   image: kuberpult-cd-service
+# By default, kuberpult allows names of apps to be max 39 characters.
+# This is usually enough. If you want to extend the length to up to 70 characters,
+# You need to ensure that ArgoCD has no issue with this. Set the Argo CD helm parameter:
+# `configs.cm.application.resourceTrackingMethod: annotation+label`
+# Note that there is no simple way in kuberpult to rename an app.
+  allowLongAppNames: false
   backendConfig:
     create: false   # Add backend config for health checks on GKE only
     timeoutSec: 300  # 30sec is the default on gcp loadbalancers, however kuberpult needs more with parallel requests. It is the time how long the loadbalancer waits for kuberpult to finish calls to the rest endpoint "release"

docker-compose-earthly.yml

@@ -10,6 +10,7 @@ services:
       - KUBERPULT_DEX_ENABLED=false
       - KUBERPULT_GIT_WRITE_COMMIT_DATA=true
       - KUBERPULT_MAXIMUM_QUEUE_SIZE=2
+      - KUBERPULT_ALLOW_LONG_APP_NAMES=true
     ports:
       - "8080:8080"
       - "8443:8443"

docker-compose.yml

@@ -15,6 +15,7 @@ services:
       - KUBERPULT_DEX_ENABLED=false
       - KUBERPULT_GIT_NETWORK_TIMEOUT=3s
       - KUBERPULT_GIT_WRITE_COMMIT_DATA=true
+      - KUBERPULT_ALLOW_LONG_APP_NAMES=true
     ports:
       - "8080:8080"
       - "8443:8443"

pkg/valid/validations.go

@@ -17,26 +17,39 @@ Copyright 2023 freiheit.com*/
 package valid
 
 import (
+	"os"
 	"regexp"
 	"strings"
 )
 
 const (
-	MaxAppNameLen        = 39
-	AppNameRegExp        = `\A[a-z0-9]+(?:-[a-z0-9]+)*\z`
-	TeamNameRegExp       = AppNameRegExp
-	EnvNameRegExp        = AppNameRegExp
-	SHA1CommitIDLength   = 40
-	commitIDPrefixRegExp = `^[0-9a-fA-F]*$`
+	FallbackMaxAppNameLength       = 39
+	LongAppNameLength              = 70
+	KUBERPULT_ALLOW_LONG_APP_NAMES = "KUBERPULT_ALLOW_LONG_APP_NAMES"
+	AppNameRegExp                  = `\A[a-z0-9]+(?:-[a-z0-9]+)*\z`
+	TeamNameRegExp                 = AppNameRegExp
+	EnvNameRegExp                  = AppNameRegExp
+	SHA1CommitIDLength             = 40
+	commitIDPrefixRegExp           = `^[0-9a-fA-F]*$`
 )
 
 var (
 	applicationNameRx = regexp.MustCompile(AppNameRegExp)
 	teamNameRx        = regexp.MustCompile(TeamNameRegExp)
 	envNameRx         = regexp.MustCompile(EnvNameRegExp)
 	commitIDPrefixRx  = regexp.MustCompile(commitIDPrefixRegExp)
+	MaxAppNameLen     = setupMaxAppNameLen()
 )
 
+func setupMaxAppNameLen() int {
+	maxAppNameLength := FallbackMaxAppNameLength
+	res, ok := os.LookupEnv(KUBERPULT_ALLOW_LONG_APP_NAMES)
+	if ok && res == "true" {
+		maxAppNameLength = LongAppNameLength
+	}
+	return maxAppNameLength
+}
+
 // {application}-{environment} should be a valid dns name
 func EnvironmentName(env string) bool {
 	return len(env) < 21 && envNameRx.MatchString(env)

services/cd-service/pkg/cmd/server.go

@@ -82,6 +82,7 @@ type Config struct {
 	GitWebUrl                string        `default:"" split_words:"true"`
 	GitMaximumCommitsPerPush uint          `default:"1" split_words:"true"`
 	MaximumQueueSize         uint          `default:"5" split_words:"true"`
+	AllowLongAppNames        bool          `default:"false" split_words:"true"`
 }
 
 func (c *Config) storageBackend() repository.StorageBackend {
@@ -218,6 +219,7 @@ func RunServer() {
 			WriteCommitData:        c.GitWriteCommitData,
 			MaximumCommitsPerPush:  c.GitMaximumCommitsPerPush,
 			MaximumQueueSize:       c.MaximumQueueSize,
+			AllowLongAppNames:      c.AllowLongAppNames,
 		}
 		repo, repoQueue, err := repository.New2(ctx, cfg)
 		if err != nil {

services/cd-service/pkg/repository/repository.go

@@ -193,14 +193,14 @@ type RepositoryConfig struct {
 	// if set, kuberpult will generate push events to argoCd whenever it writes to the manifest repo:
 	ArgoWebhookUrl string
 	// the url to the git repo, like the browser requires it (https protocol)
-	WebURL          string
-	DogstatsdEvents bool
-	WriteCommitData bool
-	WebhookResolver WebhookResolver
-
+	WebURL                string
+	DogstatsdEvents       bool
+	WriteCommitData       bool
+	WebhookResolver       WebhookResolver
 	MaximumCommitsPerPush uint
-
-	MaximumQueueSize uint
+	MaximumQueueSize      uint
+	// Extend maximum AppName length
+	AllowLongAppNames bool
 }
 
 func openOrCreate(path string, storageBackend StorageBackend) (*git.Repository, error) {

services/cd-service/pkg/repository/transformer.go

@@ -393,7 +393,7 @@ func (c *CreateApplicationVersion) Transform(
 	}
 	fs := state.Filesystem
 	if !valid.ApplicationName(c.Application) {
-		return "", GetCreateReleaseAppNameTooLong(c.Application, valid.AppNameRegExp, valid.MaxAppNameLen)
+		return "", GetCreateReleaseAppNameTooLong(c.Application, valid.AppNameRegExp, uint32(valid.MaxAppNameLen))
 	}
 	releaseDir := releasesDirectoryWithVersion(fs, c.Application, version)
 	appDir := applicationDirectory(fs, c.Application)

services/frontend-service/src/ui/components/SideBar/SideBar.scss

@@ -71,6 +71,7 @@ Copyright 2023 freiheit.com*/
 
 .mdc-drawer-sidebar-list-item-text-summary {
     @extend .text-regular;
+    word-break: break-word;
 }
 
 .mdc-drawer-sidebar-list-item-delete-all {