fix(dex): Add correct dex service name and mux #1534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kuberpult-dex
http.DefaultServeMux
but the mux which was served washttp.NewServeMux()
Now when you try to access any of
if
c.DexEnabled
you should get forwarded.For setup of the values.yaml (I only paste dex-relevant stuff, of course you'd also need a manifest repo connected etc.):
Remark:
dex.config.connectors[0].config.clientID
is used for authentication with e.g. GitHubauth.dexAuth.clientID
is another one which matches the staticClient atdex.staticClients[0].id
Now with this setup replacing:
kuberpult.example.com
with your hostnameGITHUB_OAUTH_CLIENT_ID
with your oauth client ID created in your GitHub OrgGITHUB_OAUTH_CLIENT_SECRET
with your oauth client secret created in your GitHub Orgyour-github-org
with the name of your github-orgIt should also work for you.
And of course you need to switch the image in
frontend-service
to the version of this PR.Which was a little tricky for testing as
frontend.tag
option is not allowed the values anymore. I just patched the deployment in my cluster afterwards manually.Afterwards access
kuberpult.example.com/environments
-> you will get redirected to GitHub login:Then a cookie will be set:
Which also contains the relevant information:
Originally opened by @jdvgh
Closes #1510