fix(db): replace sequence prediction #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
services/manifest-repo-export-service/pkg/repository/repository.go
Outdated
Show resolved
Hide resolved
ahmed-nour-fdc
requested changes
Jul 12, 2024
The original attempt was to read "last_value" of a squence to determine the *next* Primary Key and also write it into the json blob. This was error prone, and especially failed on the first startup (with an "empty" sequence). This PR changes this approach. It was necessary to add an interface function to set the transformer ID. Background: The transformer ID is required for the commit events, so that we can easily find all commit events of one transformer.
sven-urbanski-freiheit-com
force-pushed
the
su-db-fix-transformer-id
branch
from
2f73f49
to
4c9a02e
Compare
ahmed-nour-fdc
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original attempt was to read "last_value" of a squence to determine the next Primary Key and also write it into the json blob.
This was error prone, and especially failed on the first startup (with an "empty" sequence).
This PR changes this approach. It was necessary to add an interface function to set the transformer ID.
Background: The transformer ID is required for the commit events, so that we can easily find all commit events of one transformer.