Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: narrow, but always open "planned actions" #1896

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

bjoern-michaelsen-freiheit
Copy link
Contributor

@bjoern-michaelsen-freiheit bjoern-michaelsen-freiheit commented Aug 19, 2024

  • reduced width of "planned actions" aside
  • always keep the aside open, and give it a primary color background to provide
    some hint on space separation
  • reduce whitespace use in planned actions
  • hide disabled apply button when there is nothing to apply. Note that the
    "lock message" input is also hidden, if there is no lock: if one adds a lock
    action to an empty plan, previously the input appeared, while the apply
    button was already there. The apply button stays disabled, but for different
    reasons (before: nothing to apply, after: missing lock message)

Ref: SRX-MVHTKH

@bjoern-michaelsen-freiheit bjoern-michaelsen-freiheit changed the title Bm/plannedactions WIP: Bm/plannedactions Aug 19, 2024
@bjoern-michaelsen-freiheit bjoern-michaelsen-freiheit changed the title WIP: Bm/plannedactions feat: narrow, but always open "planned actions" Aug 20, 2024
- also squeeze filters as we pushed way too many in
@bjoern-michaelsen-freiheit
Copy link
Contributor Author

old:
image

new:
image

@bjoern-michaelsen-freiheit bjoern-michaelsen-freiheit force-pushed the bm/plannedactions branch 2 times, most recently from 24ef325 to b1b9cb5 Compare August 23, 2024 12:55
@bjoern-michaelsen-freiheit bjoern-michaelsen-freiheit merged commit bc902e9 into main Aug 23, 2024
16 checks passed
@bjoern-michaelsen-freiheit bjoern-michaelsen-freiheit deleted the bm/plannedactions branch August 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants