fix(db): Do not run deployment migrations #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this migration is not technically required. It was just there to provide additional context to the user. It only influences the UI, not what was actually deployed. For now, we remove it. The migration itself seems fine, but the dection IF the migration is necessary is flawed, leading the cd-service to potentially clone the git repo, even if it is not necessary. Ref: SRX-YNEAHU
miguel-crespo-fdc
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this migration is not technically required. It was just there to provide additional context to the user. It only influences the UI, not what was actually deployed.
For now, we remove it. The migration itself seems fine, but the dection IF the migration is necessary is flawed, leading the cd-service to potentially clone the git repo, even when it is not necessary. And that is a very costly operation with large git repos.
Ref: SRX-YNEAHU