Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep Netmask map results around, instead of re-computing each time #13

Merged
merged 1 commit into from
Apr 16, 2021
Merged

keep Netmask map results around, instead of re-computing each time #13

merged 1 commit into from
Apr 16, 2021

Conversation

newhouse
Copy link
Contributor

It seemed unnecessary / inefficient to build up the blocks array during each call to ipv4_check.

This change builds the Netmask array map, and keeps it around for re-use during each ipv4_check call.

@frenchbread
Copy link
Owner

Thanks for the PR, @newhouse.

Merging.

@frenchbread frenchbread merged commit 6c6453b into frenchbread:master Apr 16, 2021
@newhouse
Copy link
Contributor Author

You're welcome!

Any idea when you'll publish a new version with this change? I'd like to update my package...

@newhouse newhouse deleted the newhouse/v4-range-efficiency branch April 16, 2021 14:09
@frenchbread
Copy link
Owner

@newhouse, v2.2.1 version has already been published and should be available via npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants