Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Support New Ledger Wallet App #2011

Closed
8 tasks done
wilwade opened this issue Jun 5, 2024 · 1 comment
Closed
8 tasks done

Feature: Support New Ledger Wallet App #2011

wilwade opened this issue Jun 5, 2024 · 1 comment
Assignees
@wilwade
Labels
enhancement New feature or request
Milestone
2024 Q3 Progressi...

Comments

@wilwade
Copy link
Collaborator

wilwade commented Jun 5, 2024 •
edited
Loading

We want to support the upcoming Generic Polkadot Ledger Application on Frequency.

How to: https://forum.polkadot.network/t/new-polkadot-ledger-app/8817

Known Tasks

Waiting on...

Post Chain Updates
@wilwade wilwade added enhancement New feature or request blocked Blocked by another issue labels Jun 5, 2024
@wilwade wilwade added the discussion Topic for Discussion at a Community Call label Jun 18, 2024
@wilwade wilwade removed the discussion Topic for Discussion at a Community Call label Aug 5, 2024
@wilwade wilwade assigned wilwade and unassigned enddynayn Sep 17, 2024
@wilwade wilwade removed the blocked Blocked by another issue label Sep 17, 2024
@wilwade wilwade mentioned this issue Sep 20, 2024
Merged
3 tasks
wilwade added a commit that referenced this issue Sep 23, 2024
@wilwade
Fix token symbol testnet (#2159)
a49d337 
# Goal
The goal of this PR is to fix an issue with the token symbols for
testnet found while testing CheckMetadataHash extension.

Part of #2011 

# Discussion

- Corrected the symbols used for
`node/service/src/chain_spec/frequency_paseo.rs`
- Corrected the symbols used in the
`substrate_wasm_builder::WasmBuilder::init_with_defaults().enable_metadata_hash`
- Added a skipped e2e test that can be run to test transacting using the
`metadata_hash`
- Required: Update cargo deny exclusions
- Adjacent: Updated the API Augment packages
- Adjacent: Updated the API Augment to have all the no-op signed
extensions and remove warnings
- Adjacent: Updated the API Augment to list all the old v1 rpcs remove
warnings

# Checklist
- [x] Updated js/api-augment for Custom RPC OR Runtime API?
- [x] e2e Tests added?
- [x] Spec version incremented?

# How to Test

With the e2e test:
- Build Frequency using the feature `metadata-hash` (EZ mode: edit line
109 of `init.sh` to have it as one of the features)
- Set the `skip` in `e2e/signed-extensions/checkMetadataHash.test.ts` to
be only
- Run `make js`
- `cd e2e`
- `npm i ../js/api-augment/dist/frequency-chain-api-augment-0.0.0.tgz`
- `npm run test:serial`

1. See that the test passes
2. See that there are no warnings about signed extensions
3. See that there are no warnings about rpcs

Note: You will see an warning about `PORTABLEREGISTRY: Unable to
determine runtime Call type, cannot inspect
sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic` However
that appears to be due to an issue with the latest version of
Polkadotjs/api and not related to these changes nor does it impact the
running of the api.
@wilwade
Copy link
Collaborator Author

wilwade commented Oct 28, 2024

All work completed.

@wilwade wilwade closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilwade wilwade

Labels
enhancement New feature or request
Projects
None yet
Milestone
2024 Q3 Progressive Enhancements
Development

No branches or pull requests
2 participants
@wilwade @enddynayn