Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Polkadot 0.9.42 #1590

Merged
merged 40 commits into from
Jun 15, 2023
Merged

Upgrade to Polkadot 0.9.42 #1590

merged 40 commits into from
Jun 15, 2023

Conversation

mattheworris
Copy link
Collaborator

@mattheworris mattheworris commented Jun 8, 2023 •
edited
Loading

Goal

The goal of this PR is upgrade Polkadot to v0.9.42

Polkadot Release Notes:
https://github.com/paritytech/polkadot/releases/tag/v0.9.42
https://github.com/paritytech/polkadot/releases/tag/v0.9.41
https://github.com/paritytech/polkadot/releases/tag/v0.9.40

Polkadot Release Analysis:
https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

Closes #1472
Closes #1270
Closes #1332

Discussion

  • v0.9.40 was not working and there was evidence that changes in v0.9.42 were related, so we decided to jump ahead to v0.9.42

Runtime Migrations Included

Checklist

  • Chain spec updated
  • Custom RPC OR Runtime API added/changed? Updated js/api-augment.
  • Design doc(s) updated
  • Tests added
  • Benchmarks added
  • Weights updated

Tests Performed

  • make ci-local -- Passing (includes lint, docs, unit-test and integration-test)
  • make start-native -- Successfully attached debugger when creating MSA with Polkadot UI
  • make start-relay -- Docker Containers successfully started, but too slow in emulation on Apple Silicon M2.
  • make upgrade-local -- Successfully started local relay network and upgraded to a newer test runtime.
  • make upgrade-local -- Successfully updated a node running the current version on branch main

@mattheworris mattheworris self-assigned this Jun 8, 2023
@mattheworris mattheworris changed the title Polkadot 0939 to 0942 upgrade [DRAFT] Polkadot 0939 to 0942 upgrade Jun 8, 2023
@mattheworris mattheworris force-pushed the polkadot-0939-to-0942-upgrade branch from f517dfa to fe063c5 Compare June 8, 2023 22:06
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 8, 2023
@github-actions
Copy link

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 12, 2023
@github-actions
Copy link

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions
Copy link

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit a892003.

demisx pushed a commit that referenced this pull request Jun 12, 2023
Update weights for PR #1590
a892003
@codecov
Copy link

codecov bot commented Jun 12, 2023 •
edited
Loading

Codecov Report

Merging #1590 (0e3440d) into main (c4139a9) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1590      +/-   ##
==========================================
+ Coverage   72.93%   73.02%   +0.09%     
==========================================
  Files          49       49              
  Lines        4751     4745       -6     
==========================================
  Hits         3465     3465              
+ Misses       1286     1280       -6
Impacted Files Coverage Δ
pallets/capacity/src/lib.rs 51.86% <ø> (+0.12%) ⬆️
pallets/handles/src/lib.rs 54.41% <ø> (+0.12%) ⬆️
pallets/messages/src/lib.rs 55.14% <ø> (+0.22%) ⬆️
pallets/msa/src/lib.rs 93.68% <ø> (ø)
pallets/schemas/src/lib.rs 47.34% <ø> (+0.19%) ⬆️
pallets/stateful-storage/src/lib.rs 60.42% <ø> (+0.11%) ⬆️
...requency-tx-payment/src/capacity_stable_weights.rs 100.00% <100.00%> (ø)
pallets/frequency-tx-payment/src/lib.rs 66.66% <100.00%> (+0.30%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mattheworris mattheworris changed the title [DRAFT] Polkadot 0939 to 0942 upgrade Polkadot 0939 to 0942 upgrade Jun 13, 2023
@mattheworris mattheworris marked this pull request as ready for review June 13, 2023 16:26
@mattheworris mattheworris requested a review from a team June 13, 2023 16:26
@github-actions
Copy link

⏳ Running benchmarks and calculating weights. DO NOT MERGE! A new commit will be added upon completion...

@github-actions
Copy link

✅ Finished running benchmarks. Updated weights have been committed to this PR branch in commit 5374d58.

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 14, 2023
rlaferla
rlaferla approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@rlaferla rlaferla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!! 🏆🏅

enddynayn
enddynayn reviewed Jun 15, 2023
View reviewed changes
pallets/msa/src/tests/mock.rs
@@ -45,6 +45,11 @@ frame_support::construct_runtime!(

// See https://paritytech.github.io/substrate/master/pallet_collective/index.html for
// the descriptions of these configs.
parameter_types! {
pub MaxProposalWeight: frame_support::weights::Weight =
Perbill::from_percent(50) * common_runtime::constants::MAXIMUM_BLOCK_WEIGHT;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same value as Polkadot uses. I believe it to be ok, but we will want to test governance upgrade on testnet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is in the unit testing mocks, which needed to be changed to pass the unit tests.
The value defined in runtime is (runtime/frequency/src/lib.rs):

type MaxProposalWeight = MaxCollectivesProposalWeight;

// Which resolves to this:
pub MaxCollectivesProposalWeight: Weight = Perbill::from_percent(50) * RuntimeBlockWeights::get().max_block;

@wilwade wilwade mentioned this pull request Jun 15, 2023
Closed
wilwade
wilwade reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One open question on the metadata_at stuff, otherwise all good to go from my side!

Additional tests run:

  • Build mainnet and it connected to the network ✅
  • Export metadata still works ✅

@mattheworris mattheworris requested a review from a team June 15, 2023 16:36
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 15, 2023
wilwade
wilwade approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Lots of great work in there. Thanks!

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 15, 2023
enddynayn
enddynayn approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 💯

@mattheworris mattheworris mentioned this pull request Jun 15, 2023
Closed
2 tasks
@mattheworris mattheworris merged commit 6d9e542 into main Jun 15, 2023
@mattheworris mattheworris deleted the polkadot-0939-to-0942-upgrade branch June 15, 2023 21:13
@demisx demisx added the change/major Major Changes in this PR label Jun 16, 2023
@demisx demisx changed the title Polkadot 0939 to 0942 upgrade Upgrade to Polkadot 0.9.42 Jun 16, 2023
This was referenced Jun 20, 2023
Closed
Closed
Closed
Closed
Merged
wilwade added a commit that referenced this pull request Jun 20, 2023
@wilwade
Update all remaining minor Dependencies (#1608)
b4abdf0 
# Goal
The goal of this PR is to update all remaining dependencies.

In part a follow up to #1590

# Discussion
- The 0.9.42 branch had moved to
`9326fee1fb853be3d5096a2beef5fb46624e9d75` Polkadot release did as well.
https://github.com/paritytech/substrate/commits/polkadot-v0.9.42
- General upgrade of additional packages
shannonwells pushed a commit that referenced this pull request Apr 16, 2024
@mattheworris @rlaferla @shannonwells
Polkadot 0939 to 0942 upgrade (#1590)
2378d40 
# Goal
The goal of this PR is upgrade Polkadot to v0.9.42

Polkadot Release Notes:
https://github.com/paritytech/polkadot/releases/tag/v0.9.42
https://github.com/paritytech/polkadot/releases/tag/v0.9.41
https://github.com/paritytech/polkadot/releases/tag/v0.9.40

Polkadot Release Analysis:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

Closes #1472 
Closes #1270 
Closes #1332 

# Discussion
- v0.9.40 was not working and there was evidence that changes in v0.9.42
were related, so we decided to jump ahead to v0.9.42
<!-- List discussion items -->
# Runtime Migrations Included
- [x] paritytech/polkadot#6937
- [x] paritytech/substrate#13715
- [x] paritytech/substrate#13936
- [x] paritytech/polkadot#7114
- [x] Further all migrations from 9.38+ are included:
paritytech/polkadot#7162)
# Checklist
- [x] Chain spec updated
- [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
- [ ] Design doc(s) updated
- [ ] Tests added
- [ ] Benchmarks added
- [x] Weights updated
# Tests Performed
- [x] `make ci-local` -- Passing (includes lint, docs, unit-test and
integration-test)
- [x] `make start-native` -- Successfully attached debugger when
creating MSA with Polkadot UI
- [x] `make start-relay` -- Docker Containers successfully started, but
too slow in emulation on Apple Silicon M2.
- [x] `make upgrade-local` -- Successfully started local relay network
and upgraded to a newer test runtime.
- [x] `make upgrade-local` -- Successfully updated a node running the
current version on branch `main`

---------

Co-authored-by: Frequency CI [bot] <do-not-reply@users.noreply.github.com>
Co-authored-by: Matthew Orris <--help>
Co-authored-by: Robert La Ferla <robert@onemsg.co>
shannonwells pushed a commit that referenced this pull request Apr 16, 2024
@wilwade @shannonwells
Update all remaining minor Dependencies (#1608)
fb4bc3c 
# Goal
The goal of this PR is to update all remaining dependencies.

In part a follow up to #1590

# Discussion
- The 0.9.42 branch had moved to
`9326fee1fb853be3d5096a2beef5fb46624e9d75` Polkadot release did as well.
https://github.com/paritytech/substrate/commits/polkadot-v0.9.42
- General upgrade of additional packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shannonwells shannonwells shannonwells left review comments

@enddynayn enddynayn enddynayn approved these changes

@wilwade wilwade wilwade approved these changes

@rlaferla rlaferla rlaferla approved these changes

Assignees

@mattheworris mattheworris

Labels
change/major Major Changes in this PR metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
6 participants
@mattheworris @shannonwells @rlaferla @wilwade @enddynayn @demisx