chore: Replace Currency->fungible migration for capacity pallet #1779

mattheworris · 2023-11-13T17:17:05Z

Goal

The goal of this PR is to replace the Currency trait with the fungible trait in the capacity pallet.

Discussion

The following Parity issues/PRs were used as references for changes:
Deprecate Currency - PR 12951 (Explanation of necessary changes.)
FRAME: Move pallets over to use fungible traits (Issue to track Parity's efforts to update their pallets.)
pallet vesting / update to use fungible (Example of some necessary changes.)
Fungibles: migrate Democracy pallet (Example of storage migration for Locks->Freezes.)

Changes

.cargo-deny.toml Added "multiformats" for cid crate to fix warning.
vscode/settings.json Added script that sets up the source map for the rust std library files for debugging.
Cargo.lock cargo updated.
e2e/package-lock.json npm updated.
Replaced traits as needed: Use tokens::fungible::
- InspectFungible for balance() and reducible_balance()
- InspectFreeze for balance_frozen()
- Mutate for set_balance(), mint_into()
- MutateFreeze for set_freeze(), and thaw()
Added pub enum FreezeReason to support freezes
Updated error handling as set_freeze() and thaw() can fail, so errors needed to be propagated.
Updated mocks to set MaxLocks, MaxReserves, MaxFreezes, and MaxHolds to 50, to match Balances pallet config.
Updated runtime pallet configs to use BalancesMaxXXXXXs
Updated tests with .expect() where set_freeze() or thaw() can fail.
FreezeIdentifier and RuntimeFreezeReason configured with defaults.
Updated time-release pallet to propagate errors from set_freeze/thaw.
Added v3 migration to Capacity.

Storage Migrations

The value of BalancesMaxFreezes has been updated, which will impact the storage of the Balances pallet by changing T::MaxFreezes, see the code here: substrate/frame/balances/src/lib.rs:480

	/// Freeze locks on account balances.
	#[pallet::storage]
	pub type Freezes<T: Config<I>, I: 'static = ()> = StorageMap<
		_,
		Blake2_128Concat,
		T::AccountId,
		BoundedVec<IdAmount<T::FreezeIdentifier, T::Balance>, T::MaxFreezes>,
		ValueQuery,
	>;

The previous value of T::MaxFreezes was 0 so no data could be stored in Freezes, therefore no storage migration for Freezes is needed for this change. Even if there was data in storage, it would only need to be migrated if T::MaxFreezes is decreased.

However, the current chain has data in Locks that needs to migrated to Freezes. Testing has shown that these Locks will no longer be accessible once the new traits are in place.

The Balances pallet is configured to store account data using the System pallet. Therefore, these two pallets must be included when using try-runtime for testing.

The migration for Capacity will access its storage to determine which accounts have Locks that need to be translated to Freezes. Then, the old Currency trait is used to remove the Locks and the new fungible trait is used to set the Freeze.

How to Review

Read through Deprecate Currency - PR 12951 to understand context and check that Currency traits were properly replaced with fungible traits.
Check impact of changing to set_freeze() and thaw() which can now fail and make sure all error states are propagated correctly without possibility for panic
Check if balance() is used correctly, or should be changed to reducible_balance(). The calculations evaluating the Existential Deposit (ED) have been updated and Parity comments indicate that reducible_balance() is most likely the value needed.
Ensure that the migration weights calculations are correct. (Please let me know if you would like to walk through the migration code path together).

How to Test Runtime Migrations

Install the CLI version of try-runtime, then run try-runtime to test the migration against Frequency Rococo:

cargo build --release --features frequency-rococo-testnet,try-runtime && \
try-runtime --runtime ./target/release/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://rpc.rococo.frequency.xyz:443 -pallet  Capacity  --pallet Balances --pallet System

Alternatively, you can use the non-release version for faster compiles:

cargo build --features frequency-rococo-testnet,try-runtime && \
try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://rpc.rococo.frequency.xyz:443 -pallet  Capacity --pallet Balances --pallet System

You should see output like this:

[2023-12-16T17:03:57Z INFO  runtime::capacity] migrated 344
[2023-12-16T17:03:57Z INFO  runtime::capacity] migrated 345
[2023-12-16T17:03:57Z INFO  runtime::capacity] migrated 346
[2023-12-16T17:03:57Z INFO  runtime::capacity] migrated 347
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migration finished  
[2023-12-16T17:03:57Z INFO  runtime::capacity] Migration calculated weight = Weight { ref_time: 78200000000, proof_size: 0 }
[2023-12-16T17:03:57Z INFO  runtime::capacity] ✅ migration post_upgrade checks passed

// end of Capacity v2 migration, v3 migration follows

[2023-12-16T17:03:57Z INFO  runtime::capacity] Running pre_upgrade...
[2023-12-16T17:03:57Z INFO  runtime::capacity] Finish pre_upgrade for 347 records
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 Capacity Locks->Freezes migration started
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0xac4e66be328c4d235be27fcb0af8ccbe12dce375236f9ccc5516780522bc8870, amount:1500000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x3048b40a2e7185e510b695c7ba15f31218a1d4a501c6a71596e4f60317fc180f, amount:800000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x663ea97a6b40a51ed79f3328f9629423e5525c84bb178e63a854e4ce497fde25, amount:900000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x1488b10710285607257cbaa5f2ee273b50613358c50e443b8e43790ba7e15705, amount:900000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x283ac37222b6e34afb4b187e41e8e828c2e2d2b7f5bc027a2bf98eccbca76d47, amount:200000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x1a038c038ece2448a22096697a35905a98cc14138666432a1767142e67f76414, amount:900000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0xa848c35ccb975405ceec7d275d2cbbfe0df577f54a4e87caee5a4bf64f68ad01, amount:500000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x2aa39545e21212127c97ce1059988eb7f8dabe94f61e023bde1b85fd9625a638, amount:1000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x9404948a1b48c6818117f5803e5b868515fc88d1bcbd6fa27a1083089e5b5604, amount:900000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0xa0e340ec2c110a262b3f730c1cd333d52d6bb9fcb0b149bdd7216fb8cd4b2468, amount:100000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x28d9dadd32d1864fa4aa553a74ff82637acb131079bfec5b2777df7dea4a2e5d, amount:900000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0x4c54252a95ae9e334be70375d14d51d4d89a6ae2deeaf9ca47091d797f319620, amount:200000000
[2023-12-16T17:03:57Z INFO  runtime::capacity] 🔄 migrated account 0xe2133699b4fdc8444b98f9fddc7039374302a9a41e9ce53eafab113fd236c739, amount:200000000

The total weight calculated for the Capacity migration on testnet:

[2023-12-18T14:50:36Z INFO  runtime::capacity] total accounts migrated from locks to freezes: 347
[2023-12-18T14:50:36Z INFO  runtime::capacity] 🔄 Capacity Locks->Freezes migration finished
[2023-12-18T14:50:36Z INFO  runtime::capacity] Capacity Migration calculated weight = Weight { ref_time: 260375000000, proof_size: 0 }
[2023-12-18T14:50:36Z INFO  runtime::capacity] ✅ migration post_upgrade checks passed

The total weight calculated for the Capacity migration on main net:

[2023-12-18T14:57:04Z INFO  runtime::capacity] 🔄 Capacity Locks->Freezes migration finished
[2023-12-18T14:57:04Z INFO  runtime::capacity] Capacity Migration calculated weight = Weight { ref_time: 1625000000, proof_size: 0 }
[2023-12-18T14:57:04Z INFO  runtime::capacity] ✅ migration post_upgrade checks passed

Upgrade Notes

scripts/upgrade_accounts.py should be executed to ensure that all accounts have been upgraded before running the migration.

Checklist

…e maps;

pallets/capacity/src/lib.rs

aramikm

Added some comments. I'm a bit worried about the total weight on test-net since it's around 40% of the block capacity + time-release changes alone and if another migration comes on top of those then it would be getting closer to the limit.

pallets/capacity/src/lib.rs

aramikm · 2023-12-18T19:32:04Z

scripts/upgrade_accounts.py

+print(f"Connected to {chain.name}: {chain.chain} v{chain.version}")
+
+sender_uri = os.getenv('SENDER_URI', '//Alice')
+sender = Keypair.create_from_uri(sender_uri)


This might work with testnet but who is going to pay for upgrades on main-net?

If more than 90% of the accounts need to be upgraded, then it is a free transaction. See here:
https://github.com/paritytech/polkadot-sdk/blob/f93f461acc24022bf7ef07c5913e620121776708/substrate/frame/balances/src/lib.rs#L685

pallets/time-release/src/migration/v2.rs

pallets/capacity/src/migration/v3.rs

…' of https://github.com/LibertyDSNP/frequency into 942-capacity-replace-currency-trait-with-fungible-trait

enddynayn

Nice! Some small comments but no blockers. Amazing work.

shannonwells

I will run the migration as well but I wanted to get these comments in first.

pallets/capacity/src/migration/v3.rs

…ss comments

shannonwells

This one is blocking because of the referenced PR - I think we should discuss the implications of this comment first:

Freezes are essentially the same as locks, except that they overlap with Holds. Since Holds are designed to be infallibly slashed, this means that any logic using a Freeze must handle the possibility of the frozen amount being reduced, potentially to zero. A permissionless function should be provided in order to allow bookkeeping to be updated in this instance.

This PR adds no such permissionless function. If I'm reading this correctly, the frozen amount is somehow reduced to zero particularly through slashing, then the unlocks will need to be reduced or cleared. I think this is a nonzero possibility because a lot of Providers, who will be staking, will also be running their own nodes. Maybe they would use different collator keys than staking keys, and maybe they wouldn't. I'm not sure what such a function would look like or by what mechanism it would be called.

Re: reducible_balance - based on my reading, this is <= balance, and the only reason ever to use this is in operations where we don't need to keep the system account alive, and there are no instances of that here.

Read through Deprecate Currency; introduce holds and freezing into fungible traits paritytech/substrate#12951 to understand context and check that Currency traits were properly replaced with fungible traits.
Check impact of changing to set_freeze() and thaw() which can now fail and make sure all error states are propagated correctly without possibility for panic
Check if balance() is used correctly, or should be changed to reducible_balance(). The calculations evaluating the Existential Deposit (ED) have been updated and Parity comments indicate that reducible_balance() is most likely the value needed.
Ensure that the migration weights calculations are correct. (comments relating to this added already)

shannonwells

As agreed in the standup parking lot, let's create a new issue for the question I raised, which includes writing some tests to check the behavior.

aramikm

Looks great. Tremendous effort. It is recommended that we release these heavier migration included PR's separately so that it would not overflow the block size on testnet.

for time-release pallet Initial code changes Split from PR #1779

…1818) # Goal The goal of this PR is to replace the `Currency` trait with the `fungible` trait in the `time-release` pallet. This work was split from PR #1779. Closes #942 Closes #1833 # Discussion The following Parity issues/PRs were used as references for changes: [Deprecate Currency - PR 12951](paritytech/substrate#12951) (Explanation of necessary changes.) [FRAME: Move pallets over to use fungible traits](paritytech/polkadot-sdk#226) (Issue to track Parity's efforts to update their pallets.) [pallet vesting / update to use fungible](https://github.com/paritytech/polkadot-sdk/pull/1760/files) (Example of some necessary changes.) [Fungibles: migrate Democracy pallet](paritytech/polkadot-sdk#1861) (Example of storage migration for Locks->Freezes.) # Changes - Replaced traits as needed: Use `tokens::fungible::` - `InspectFungible` for `balance()` and `reducible_balance()` - `InspectFreeze` for `balance_frozen()` - `Mutate` for `set_balance()`, `mint_into()` - `MutateFreeze` for `set_freeze()`, and `thaw()` - Added `pub enum FreezeReason` to support `freezes` - Updated error handling as `set_freeze()` and `thaw()` can fail, so errors needed to be propagated. - Updated runtime pallet configs to use BalancesMaxXXXXXs - Updated tests with `.expect()` where `set_freeze()` or `thaw()` can fail. - `FreezeIdentifier` and `RuntimeFreezeReason` configured with defaults. - Updated time-release pallet to propagate errors from set_freeze/thaw. - Added v2 migration to TimeRelease. # Storage Migrations The value of `BalancesMaxFreezes` has been updated, which will impact the storage of the Balances pallet by changing `T::MaxFreezes`, see the code here: [substrate/frame/balances/src/lib.rs:480](https://github.com/paritytech/polkadot-sdk/blob/release-polkadot-v1.1.0/substrate/frame/balances/src/lib.rs#L480) ```rust /// Freeze locks on account balances. #[pallet::storage] pub type Freezes<T: Config<I>, I: 'static = ()> = StorageMap< _, Blake2_128Concat, T::AccountId, BoundedVec<IdAmount<T::FreezeIdentifier, T::Balance>, T::MaxFreezes>, ValueQuery, >; ``` The previous value of `T::MaxFreezes` was `0` so no data could be stored in `Freezes`, therefore no storage migration for `Freezes` is needed for this change. Even if there was data in storage, it would only need to be migrated if `T::MaxFreezes` is *decreased*. However, the current chain has data in `Locks` that needs to migrated to `Freezes`. Testing has shown that these `Locks` will no longer be accessible once the new traits are in place. The `Balances` pallet is configured to store account data using the `System` pallet. Therefore, these two pallets must be included when using `try-runtime` for testing. The migration for `TimeRelease` will access its storage to determine which accounts have `Locks` that need to be translated to `Freezes`. Then, the old `Currency` trait is used to remove the `Locks` and the new `fungible` trait is used to set the `Freeze`. # How to Review - [x] Read through [Deprecate Currency - PR 12951](paritytech/substrate#12951) to understand context and check that Currency traits were properly replaced with fungible traits. - [ ] Check impact of changing to `set_freeze()` and `thaw()` which can now fail and make sure all error states are propagated correctly without possibility for `panic` - [ ] Check if `balance()` is used correctly, or should be changed to `reducible_balance()`. The calculations evaluating the Existential Deposit (ED) have been updated and Parity comments indicate that `reducible_balance()` is most likely the value needed. - [ ] Ensure that the migration weights calculations are correct. (Please let me know if you would like to walk through the migration code path together). # How to Test Runtime Migrations [Install the CLI version of try-runtime](https://paritytech.github.io/try-runtime-cli/try_runtime/#installation), then run try-runtime to test the migration against Frequency Rococo: ```bash cargo build --release --features frequency-rococo-testnet,try-runtime && \ try-runtime --runtime ./target/release/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://rpc.rococo.frequency.xyz:443 --pallet TimeRelease --pallet Balances --pallet System ``` Alternatively, you can use the non-release version for faster compiles: ```bash cargo build --features frequency-rococo-testnet,try-runtime && \ try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://rpc.rococo.frequency.xyz:443 --pallet TimeRelease --pallet Balances --pallet System ``` And for testing on main-net: ```bash cargo build --features frequency,try-runtime && \ try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://1.rpc.frequency.xyz:443 --pallet Balances --pallet System --pallet TimeRelease ``` Testing with a snapshot: ```bash # create a snapshot (or use existing one) try-runtime create-snapshot --uri https:://rpc.rococo.frequency.xyz:443 testnet-all-pallets.state # use the testnet snapshot cargo build --features frequency-rococo-testnet,try-runtime && \ try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade \ snap --path testnet-all-pallets.state # use the mainnet snapshot cargo build --features frequency,try-runtime && \ try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade \ snap --path mainnet-all-pallets.state ``` You should see output like this: ```bash [2023-12-20T22:06:50Z INFO runtime::time-release] Running pre_upgrade... [2023-12-20T22:06:50Z INFO runtime::time-release] Finish pre_upgrade for 6 records [2023-12-20T22:06:50Z INFO runtime::time-release] Running storage migration... [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 Time Release Locks->Freezes migration started [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 migrated account 0x702cfcc9149d3c6f65728d3a5312d66a83fb70ed942cedb8e6450f4198ce7a77, amount:1000000000 [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 migrated account 0xce3bcb8ac19cdeb3ee14173be5f474292ff11ae56d4d0fa3f2bdaf24b4ef5842, amount:10000000000000 [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 migrated account 0x041a99f3614052bdd5b0aed6ed5805f592aacbcc0d5a443821f3b4339c44c11f, amount:400000050 [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 migrated account 0x26db9b4eeb5b5d511abd26903a25578f355e34e33316aeb2d34e846045cc7e45, amount:10000000000 [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 migrated account 0xc8d6262ff9fc322e59bcd36a36e310cfc7c50134e309a82f4330648e2eff7368, amount:1411 [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 migrated account 0x485dc3b17bcebba3013e47150e588c941a1f9778378367125e98a2e8f140325e, amount:3000000000 [2023-12-20T22:06:50Z INFO runtime::time-release] total accounts migrated from locks to frozen 6 [2023-12-20T22:06:50Z INFO runtime::time-release] 🔄 Time Release migration finished [2023-12-20T22:06:50Z INFO runtime::time-release] Time Release Migration calculated weight = Weight { ref_time: 4525000000, proof_size: 0 } [2023-12-20T22:06:50Z INFO runtime::time-release] ✅ migration post_upgrade checks passed ``` The total weight calculated for the TimeRelease migration on testnet: ```bash [2023-12-18T14:50:36Z INFO runtime::time-release] total accounts migrated from locks to frozen 6 [2023-12-18T14:50:36Z INFO runtime::time-release] 🔄 Time Release migration finished [2023-12-18T14:50:36Z INFO runtime::time-release] Time Release Migration calculated weight = Weight { ref_time: 4525000000, proof_size: 0 } [2023-12-18T14:50:36Z INFO runtime::time-release] ✅ migration post_upgrade checks passed ``` The total weight calculated for the TimeRelease migration on mainnet: ```bash [2023-12-18T14:57:04Z INFO runtime::time-release] 🔄 Time Release migration finished [2023-12-18T14:57:04Z INFO runtime::time-release] Time Release Migration calculated weight = Weight { ref_time: 16525000000, proof_size: 0 } [2023-12-18T14:57:04Z INFO runtime::time-release] ✅ migration post_upgrade checks passed ``` # Upgrade Notes 1. `scripts/upgrade_accounts.py` should be executed to ensure that all accounts have been upgraded before running the migration. This step may be a no-op, if all accounts have previously been upgraded. # Checklist - [x] Chain spec updated - [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment. - [ ] Design doc(s) updated - [ ] Tests added - [ ] Benchmarks added - [ ] Weights updated --------- Co-authored-by: Matthew Orris <--help> Co-authored-by: Aramik <aramikm@gmail.com> Co-authored-by: Robert La Ferla <robert@onemsg.co>

mattheworris linked an issue Nov 13, 2023 that may be closed by this pull request

[Capacity] replace currency trait with fungible trait #942

Closed

Matthew Orris added 7 commits November 17, 2023 16:21

chore: Replace Currency->fungible: update pallet_capacity with fungible

f95a3c9

fix: keep Currency name and update derived trait

72543fa

fix: pallet_capacity tests working with correct types/traits

478ee54

fix: capacity pallet tests passing; update vscode with rust std sourc…

1befab1

…e maps;

fix: lint changes;

7fbdf01

fix: benchmarks updates for Currency trait

7eceac4

fix: time-release pallet updated with fungible traits; test working

1dad909

mattheworris force-pushed the 942-capacity-replace-currency-trait-with-fungible-trait branch from 97d61f3 to 1dad909 Compare November 17, 2023 23:22

fix: time-release runtime-benchmarks errors

02f57a0

github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Nov 18, 2023

fix: update comments; rename FreezeReason::TimeReleased

225b345

fix: enum should be the same; updates;

57d7d94

github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Nov 21, 2023

Matthew Orris added 2 commits November 21, 2023 12:05

fix: update cargo dependencies for common-runtime;

86c6e74

fix: Currency trait was incorrect;

bf228b5

enddynayn reviewed Dec 18, 2023

View reviewed changes

pallets/capacity/src/lib.rs Outdated Show resolved Hide resolved

enddynayn reviewed Dec 18, 2023

View reviewed changes

pallets/capacity/src/lib.rs Outdated Show resolved Hide resolved

aramikm reviewed Dec 18, 2023

View reviewed changes

mattheworris changed the title ~~chore: Replace Currency->fungible~~ chore: Replace Currency->fungible migration for capacity pallet Dec 18, 2023

fix: split PR into capacity and time-release portions; cargo update

d659eff

github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Dec 18, 2023

fix: address pr comments

f009805

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Dec 18, 2023

Matthew Orris added 3 commits December 18, 2023 16:42

fix: refactor migration test w/o try-runtime

e75f8ab

fix: refactor migration test w/o try-runtime

6f024a2

Merge branch '942-capacity-replace-currency-trait-with-fungible-trait…

91485bd

…' of https://github.com/LibertyDSNP/frequency into 942-capacity-replace-currency-trait-with-fungible-trait

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Dec 19, 2023

enddynayn approved these changes Dec 19, 2023

View reviewed changes

shannonwells requested changes Dec 19, 2023

View reviewed changes

fix: set_freeze before removing the locks; update FreezeReason; addre…

a0070a0

…ss comments

github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Dec 19, 2023

shannonwells reviewed Dec 19, 2023

View reviewed changes

github-actions bot added the metadata-changed Metadata has changed since the latest full release label Dec 19, 2023

shannonwells approved these changes Dec 19, 2023

View reviewed changes

mattheworris mentioned this pull request Dec 19, 2023

Investigate fungible trait Holds and Freezes overlap. #1819

Closed

6 tasks

aramikm approved these changes Dec 19, 2023

View reviewed changes

mattheworris merged commit 3d5714c into main Dec 20, 2023
30 checks passed

mattheworris deleted the 942-capacity-replace-currency-trait-with-fungible-trait branch December 20, 2023 00:30

mattheworris pushed a commit that referenced this pull request Dec 20, 2023

chore: Replace Currency->fungible: update pallet_capacity with fungible

33a70c6

for time-release pallet Initial code changes Split from PR #1779

mattheworris mentioned this pull request Dec 20, 2023

Replace Currency->fungible trait migration for time-release pallet #1818

Merged

10 tasks

mattheworris pushed a commit that referenced this pull request Dec 20, 2023

chore: Replace Currency->fungible: update pallet_capacity with fungible

e449930

for time-release pallet Initial code changes Split from PR #1779

mattheworris mentioned this pull request Feb 5, 2024

Upgrade Accounts after upgrading Currency trait to fungible. #1868

Closed

4 tasks

mattheworris mentioned this pull request Jun 24, 2024

Pallet Unit Tests concerning Balances: Modify mock.rs to have ED > 1, to test balances less than ED. #1852

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Replace Currency->fungible migration for capacity pallet #1779

chore: Replace Currency->fungible migration for capacity pallet #1779

mattheworris commented Nov 13, 2023 •

edited

Loading

aramikm left a comment

aramikm Dec 18, 2023

mattheworris Dec 18, 2023

enddynayn left a comment

shannonwells left a comment

shannonwells left a comment •

edited

Loading

shannonwells left a comment

aramikm left a comment

chore: Replace Currency->fungible migration for capacity pallet #1779

chore: Replace Currency->fungible migration for capacity pallet #1779

Conversation

mattheworris commented Nov 13, 2023 • edited Loading

Goal

Discussion

Changes

Storage Migrations

How to Review

How to Test Runtime Migrations

Upgrade Notes

Checklist

aramikm left a comment

Choose a reason for hiding this comment

aramikm Dec 18, 2023

Choose a reason for hiding this comment

mattheworris Dec 18, 2023

Choose a reason for hiding this comment

enddynayn left a comment

Choose a reason for hiding this comment

shannonwells left a comment

Choose a reason for hiding this comment

shannonwells left a comment • edited Loading

Choose a reason for hiding this comment

shannonwells left a comment

Choose a reason for hiding this comment

aramikm left a comment

Choose a reason for hiding this comment

mattheworris commented Nov 13, 2023 •

edited

Loading

shannonwells left a comment •

edited

Loading