Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release tag checking to support v1.10.0 #1831

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Jan 2, 2024

\d doesn't work as expected. Using [0-9] instead

Goal

The goal of this PR is to fix a release tagging issue

Test in bash:

[[ "v1.10.0" =~ ^v([0-9]+)\.(0|([1-9][0-9]+))\.(0|([1-9][0-9]+))(-rc[1-9][0-9]*)?$ ]] && echo "works"
[[ "v1.0.0" =~ ^v([0-9]+)\.(0|([1-9][0-9]+))\.(0|([1-9][0-9]+))(-rc[1-9][0-9]*)?$ ]] && echo "works"
[[ "v1.01.0" =~ ^v([0-9]+)\.(0|([1-9][0-9]+))\.(0|([1-9][0-9]+))(-rc[1-9][0-9]*)?$ ]] || echo "fails correctly"
[[ "v1.1.01" =~ ^v([0-9]+)\.(0|([1-9][0-9]+))\.(0|([1-9][0-9]+))(-rc[1-9][0-9]*)?$ ]] || echo "fails correctly"
[[ "v1.1.1-rc0" =~ ^v([0-9]+)\.(0|([1-9][0-9]+))\.(0|([1-9][0-9]+))(-rc[1-9][0-9]*)?$ ]] || echo "fails correctly"

\d doesn't work as expected. Using [0-9] instead
@wilwade wilwade requested a review from demisx as a code owner January 2, 2024 16:00
@wilwade wilwade requested a review from a team January 2, 2024 17:53
Copy link
Collaborator

@demisx demisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wilwade wilwade enabled auto-merge (squash) January 2, 2024 18:47
@wilwade wilwade disabled auto-merge January 2, 2024 18:52
@wilwade wilwade merged commit 14d4388 into main Jan 2, 2024
27 checks passed
@wilwade wilwade deleted the ci-update/fix-release-tag-filter branch January 2, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants