Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1824: try-runtime ci checks: Migrations #2023

Merged
merged 29 commits into from
Jun 27, 2024
Merged

#1824: try-runtime ci checks: Migrations #2023

merged 29 commits into from
Jun 27, 2024

Conversation

saraswatpuneet
Copy link
Collaborator

@saraswatpuneet saraswatpuneet commented Jun 12, 2024 •
edited
Loading

Goal

The goal of this PR is to enable try-runtime migraiton checks (pre-and-post) in CI

Details

  • Added a make target try-runtime-check-migrations-paseo-testnet to run checks locally against paseo
  • Added a github action that runs the checks.
  • Set trigger with label for the job, Adding the label change/storage-migration will trigger future CI runs for that PR to run a new job that will run the migration against testnet if: ${{ github.event.label.name == 'change/storage-migration' }}

Closes #1824

Discussion

Checklist

  • Chain spec updated
  • Custom RPC OR Runtime API added/changed? Updated js/api-augment.
  • Design doc(s) updated
  • Tests added
  • Benchmarks added
  • Weights updated

@saraswatpuneet saraswatpuneet changed the title update make file and add a job #1824: try-runtime ci checks: Migrations Jun 12, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 13, 2024
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 13, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 13, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 13, 2024
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jun 13, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 13, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 14, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 14, 2024
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 17, 2024
wilwade
wilwade reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes on some bits and pieces, but really nice to see that successful action! https://github.com/frequency-chain/frequency/actions/runs/9520722036/job/26246590160

.github/workflows/check-migrations.yml Outdated Show resolved Hide resolved
.github/workflows/common/try-runtime-migrations/action.yml Outdated Show resolved Hide resolved
.github/workflows/check-migrations.yml Outdated Show resolved Hide resolved
.github/workflows/check-migrations.yml Outdated Show resolved Hide resolved
.github/workflows/check-migrations.yml Outdated Show resolved Hide resolved
.github/workflows/common/try-runtime-migrations/action.yml Outdated Show resolved Hide resolved
saraswatpuneet
saraswatpuneet commented Jun 25, 2024
View reviewed changes
.github/workflows/check-migrations.yml

jobs:
check-migrations:
if: github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'change/storage-migration')
Copy link
Collaborator Author

@saraswatpuneet saraswatpuneet Jun 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if trigger event is a manual dispatch or a label then proceed else skip

wilwade
wilwade approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work.

@wilwade wilwade requested review from a team, shannonwells, mattheworris, enddynayn, aramikm, claireolmstead and JoeCap08055 and removed request for a team June 26, 2024 12:05
mattheworris
mattheworris approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through changes
  • make test passed
  • make try-runtime-check-migrations-paseo-testnet [working]

Nice work!
🚢 it!

@saraswatpuneet saraswatpuneet enabled auto-merge (squash) June 26, 2024 17:20
shannonwells
shannonwells approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I also ran make test and make try-runtime-check-migrations-paseo-testnet, works on my machine

@saraswatpuneet saraswatpuneet merged commit 944ea1b into main Jun 27, 2024
28 checks passed
@saraswatpuneet saraswatpuneet deleted the try_runtime_migrations branch June 27, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworris mattheworris mattheworris approved these changes

@wilwade wilwade wilwade approved these changes

@shannonwells shannonwells shannonwells approved these changes

@demisx demisx Awaiting requested review from demisx demisx is a code owner

@enddynayn enddynayn Awaiting requested review from enddynayn enddynayn was automatically assigned from frequency-chain/pr-reviewers

@aramikm aramikm Awaiting requested review from aramikm aramikm was automatically assigned from frequency-chain/pr-reviewers

@claireolmstead claireolmstead Awaiting requested review from claireolmstead claireolmstead was automatically assigned from frequency-chain/pr-reviewers

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055 JoeCap08055 was automatically assigned from frequency-chain/pr-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Be able to trigger try runtime for migrations locally and in CI
4 participants
@saraswatpuneet @shannonwells @wilwade @mattheworris