Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(upgrade): v1.5.0 to v1.6.0 #2046

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

enddynayn
Copy link
Collaborator

@enddynayn enddynayn commented Jun 27, 2024

  • Upgrade Polkadot-sdk to v.1.6.0.
  • Update weights to reflect the new version.

Notable Changes:

For more details, please refer to:

Release Notes
Release Analysis

#1841

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch from ab9952e to 3fd02fc Compare June 27, 2024 16:03
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pallets/handles/src/lib.rs 91.45% <100.00%> (ø)
pallets/msa/src/lib.rs 88.07% <100.00%> (ø)

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 27, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch from 326382b to be21de8 Compare June 27, 2024 18:59
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 27, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch from be21de8 to c558481 Compare June 27, 2024 19:05
@enddynayn enddynayn changed the title Chore/upgrade polkadot v1.5.0 to v1.6.0 issue 1841 chore(upgrade): v1.5.0 to v1.6.0 Jun 27, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 27, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch from ee60b82 to 091e0e8 Compare June 27, 2024 21:26
@enddynayn enddynayn marked this pull request as ready for review June 27, 2024 21:26
@enddynayn enddynayn requested a review from wilwade as a code owner June 27, 2024 21:26
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 27, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 27, 2024
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go. I did not look through the substrate pallet weight changes. I did look through our custom pallet weight changes. The biggest differences that I noticed were lowered weights.

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch from 091e0e8 to 9e982d0 Compare June 27, 2024 22:05
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jun 27, 2024
Cargo.toml Outdated Show resolved Hide resolved
@@ -39,7 +39,8 @@ pub enum Subcommand {
PurgeChain(cumulus_client_cli::PurgeChainCmd),

/// Export the genesis state of the parachain.
ExportGenesisState(cumulus_client_cli::ExportGenesisStateCommand),
#[command(alias = "export-genesis-state")]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking unused dependency removal and the e2e test needing a decreased amount due to the lower cost

  • Reviewed code

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch from 9e982d0 to 83a4123 Compare June 28, 2024 15:26
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jun 28, 2024
- Upgrade Polkadot-sdk to v.1.6.0.
- Update weights to reflect the new version.
- Modify extrinsic weight test due to an improvement in weights.

Notable Changes:
- [Rename ExportGenesisStateCommand to ExportGenesisHeadCommand ](paritytech/polkadot-sdk#2331)

For more details, please refer to:

[Release
Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.6.0)
[Release
Analysis](https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/58550)

issue-1841
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch from 83a4123 to 236ac96 Compare June 28, 2024 15:28
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jun 28, 2024
Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Read through changes
    Nice work!
    🚢 it!

@enddynayn enddynayn merged commit d1adbc6 into main Jun 28, 2024
26 checks passed
@enddynayn enddynayn deleted the chore/upgrade-polkadot-v1.5.0-to-v1.6.0-issue-1841 branch June 28, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants