-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(upgrade): v1.5.0 to v1.6.0 #2046
chore(upgrade): v1.5.0 to v1.6.0 #2046
Conversation
ab9952e
to
3fd02fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
326382b
to
be21de8
Compare
be21de8
to
c558481
Compare
ee60b82
to
091e0e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to go. I did not look through the substrate pallet weight changes. I did look through our custom pallet weight changes. The biggest differences that I noticed were lowered weights.
091e0e8
to
9e982d0
Compare
@@ -39,7 +39,8 @@ pub enum Subcommand { | |||
PurgeChain(cumulus_client_cli::PurgeChainCmd), | |||
|
|||
/// Export the genesis state of the parachain. | |||
ExportGenesisState(cumulus_client_cli::ExportGenesisStateCommand), | |||
#[command(alias = "export-genesis-state")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking unused dependency removal and the e2e test needing a decreased amount due to the lower cost
- Reviewed code
9e982d0
to
83a4123
Compare
- Upgrade Polkadot-sdk to v.1.6.0. - Update weights to reflect the new version. - Modify extrinsic weight test due to an improvement in weights. Notable Changes: - [Rename ExportGenesisStateCommand to ExportGenesisHeadCommand ](paritytech/polkadot-sdk#2331) For more details, please refer to: [Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.6.0) [Release Analysis](https://forum.polkadot.network/t/polkadot-release-analysis-v1-6-0/58550) issue-1841
83a4123
to
236ac96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read through changes
Nice work!
🚢 it!
Notable Changes:
For more details, please refer to:
Release Notes
Release Analysis
#1841