Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proxy e2e test funding source #2050

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix proxy e2e test funding source #2050

merged 2 commits into from
Jul 2, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Jul 2, 2024

Goal

The goal of this PR is to fix a typo of reusing the same funding source for e2e tests

Also sorts the funding sources for easier reading.

Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! 👍

@@ -49,7 +49,7 @@ describe('Capacity Transactions', function () {
describe('pay_with_capacity', function () {
describe('when caller has a Capacity account', function () {
let schemaId: u16;
const amountStaked = 2n * DOLLARS;
const amountStaked = 3n * DOLLARS;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the failing e2e tests. The weight change pushed something over that was only on the edge of working.

@wilwade wilwade marked this pull request as ready for review July 2, 2024 15:56
@wilwade wilwade merged commit cf42635 into main Jul 2, 2024
26 checks passed
@wilwade wilwade deleted the chore/e2e-test-fix branch July 2, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants