Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offchain workers custom extension #2122

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Offchain workers custom extension #2122

merged 8 commits into from
Aug 15, 2024

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Aug 13, 2024 •
edited
Loading

Goal

The goal of this PR is to ensure we are calling the correct rpc endpoint in cases that it is different from default.
Closes #1846

Checklist

  • Spec version incremented?

@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
pallets/msa/src/offchain_storage.rs 71.42% 2 Missing ⚠️
Files Coverage Δ
common/primitives/src/offchain.rs 96.15% <100.00%> (+0.26%) ⬆️
pallets/msa/src/offchain_storage.rs 79.57% <71.42%> (-0.34%) ⬇️

@aramikm aramikm marked this pull request as ready for review August 14, 2024 23:01
@aramikm aramikm requested a review from wilwade as a code owner August 14, 2024 23:01
@aramikm aramikm changed the title init: custom extension [WIP] init: custom extension Aug 15, 2024
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 15, 2024
@aramikm aramikm changed the title [WIP] init: custom extension Offchain workers custom extension Aug 15, 2024
wilwade
wilwade approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Everything worked for me!

  • Reviewed code
  • Ran locally
  • Ran e2e locally
  • Tested off-chain index locally

saraswatpuneet
saraswatpuneet approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

JoeCap08055
JoeCap08055 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aramikm aramikm merged commit 05e8acd into main Aug 15, 2024
27 checks passed
@aramikm aramikm deleted the custom_extension_ocw branch August 15, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@wilwade wilwade wilwade approved these changes

@mattheworris mattheworris Awaiting requested review from mattheworris

@enddynayn enddynayn Awaiting requested review from enddynayn

@claireolmstead claireolmstead Awaiting requested review from claireolmstead

@shannonwells shannonwells Awaiting requested review from shannonwells

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

offchain worker: pass rpc params from node into worker
4 participants
@aramikm @wilwade @saraswatpuneet @JoeCap08055