Schema Migration fix for newer mainnet schema data

[wilwade]

Goal

The goal of this PR is to update the schemas migration with respect to the newer data on chain.

Part of #2006

Discussion

• Only reset the name list as needed
• Add in schema 19 so that it is re-added at the top of the list

Result of try-runtime

[2024-09-26T20:42:48Z INFO runtime::schemas] Running pre_upgrade...
[2024-09-26T20:42:48Z INFO runtime::schemas] Running storage migration...
[2024-09-26T20:42:48Z INFO runtime::schemas] Storage migrated to version 4 read=15, write=15, bytes=11138
[2024-09-26T20:42:48Z INFO runtime::schemas] Migration Calculated weights=Weight { ref_time: 1824840000, proof_size: 11138 }
[2024-09-26T20:42:48Z INFO runtime::schemas] Running post_upgrade...
[2024-09-26T20:42:48Z INFO runtime::schemas] Finished post_upgrade

[codecov]

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pallets/schemas/src/migration/v4.rs	18.18%	9 Missing ⚠️

Files with missing lines	Coverage Δ
pallets/schemas/src/migration/v4.rs	40.29% <18.18%> (-1.24%)	⬇️

[aramikm]

here is the command I ran to check the migration against the mainnet. You need to compile the runtime with frequency and try-runtime flags

cargo build --features frequency,try-runtime

RUST_LOG=debug try-runtime --runtime ./target/debug/wbuild/frequency-runtime/frequency_runtime.wasm on-runtime-upgrade live --uri wss://1.rpc.frequency.xyz:443 --pallet System --pallet Schemas

[aramikm]

Looks good.
I would recommend to run try-runtime against mainnet for additional verification.

[enddynayn]

Great! 👍