Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support of dilation in receptive field computation #28

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Oct 23, 2020

This PR addresses the issue raised in #27 by taking dilation into account for receptive field computation.

@frgfm frgfm added type: improvement New feature or request module: modules Related to modules module: test labels Oct 23, 2020
@frgfm frgfm added this to the 0.1.2 milestone Oct 23, 2020
@frgfm frgfm self-assigned this Oct 23, 2020
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #28 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   89.46%   89.52%   +0.05%     
==========================================
  Files           9        9              
  Lines         560      563       +3     
==========================================
+ Hits          501      504       +3     
  Misses         59       59              
Impacted Files Coverage Δ
torchscan/modules/receptive.py 100.00% <100.00%> (ø)

@frgfm frgfm merged commit 4867339 into master Oct 23, 2020
@frgfm frgfm deleted the rf-dilation branch October 23, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: modules Related to modules type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant