Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fixed annotation typing #38

Merged
merged 1 commit into from
Mar 3, 2021
Merged

style: Fixed annotation typing #38

merged 1 commit into from
Mar 3, 2021

Conversation

frgfm
Copy link
Owner

@frgfm frgfm commented Mar 3, 2021

This PR fixes typing for module memory computation by specifying variable assignment type.

@frgfm frgfm added type: improvement New feature or request module: modules Related to modules labels Mar 3, 2021
@frgfm frgfm added this to the 0.1.2 milestone Mar 3, 2021
@frgfm frgfm self-assigned this Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #38 (18988e1) into master (f24904b) will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   90.14%   89.93%   -0.22%     
==========================================
  Files           9       10       +1     
  Lines         609      616       +7     
==========================================
+ Hits          549      554       +5     
- Misses         60       62       +2     
Impacted Files Coverage Δ
torchscan/modules/memory.py 100.00% <100.00%> (ø)
torchscan/__init__.py 66.66% <0.00%> (ø)

@frgfm frgfm merged commit 3529d4a into master Mar 3, 2021
@frgfm frgfm deleted the typing-fix branch March 3, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: modules Related to modules type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant