Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade profile semantics to specs-v1 #141

Merged
merged 9 commits into from
Apr 18, 2017
Merged

Upgrade profile semantics to specs-v1 #141

merged 9 commits into from
Apr 18, 2017

Conversation

roll
Copy link
Member

@roll roll commented Apr 14, 2017


In specs-v1 profiles are handled inside descriptor as descriptor.profile. This PR deprecates Datapackage.schema and schema argument and introduces Datapackage.profile instead. It makes Profile.name/jsonschema/validate public API (former Schema class) and part of Stack Reference.

Also there are some final clean-ups as linting, renaming specs dir to profiles, merging internal mappers to deprecated pushpull, adding forgotten Resource.name and specs links update in texts.

It's the last change to be compliant to specs-v1.

@roll roll added the review label Apr 14, 2017
@roll roll changed the title Updated to specs-v1 profile semantics Upgrade profile semantics to specs-v1 Apr 14, 2017
@roll roll requested a review from danfowler April 14, 2017 08:50
@roll
Copy link
Member Author

roll commented Apr 14, 2017

@danfowler
please take a look

@roll roll requested a review from amercader April 18, 2017 07:47
@roll
Copy link
Member Author

roll commented Apr 18, 2017

@amercader
please take a look

@roll roll merged commit fa04fae into master Apr 18, 2017
@roll roll deleted the profile-v1 branch April 18, 2017 12:32
@roll roll removed the review label Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analyze spec-v1 and make corresponding updates
2 participants