Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added s3 to the remote schemes #246

Merged
merged 4 commits into from
Sep 18, 2019
Merged

Added s3 to the remote schemes #246

merged 4 commits into from
Sep 18, 2019

Conversation

roll
Copy link
Member

@roll roll commented Sep 17, 2019 •
edited
Loading

Missing parts:

  • rebase on normal is_remote check (see TODO)

@roll roll changed the title [WIP] AWS Loader Added s3 to remote schemes Sep 18, 2019
@roll roll changed the title Added s3 to remote schemes Added s3 to the remote schemes Sep 18, 2019
@roll roll merged commit d1e3384 into master Sep 18, 2019
@roll roll deleted the aws-loader branch September 18, 2019 06:01
paulgirard added a commit to paulgirard/datapackage-py that referenced this pull request Aug 13, 2020
@paulgirard
use iterator for streams in multipart fixes frictionlessdata#246
c8d3ed9
roll pushed a commit that referenced this pull request Aug 14, 2020
@paulgirard
Use iterator for streams in multipart fixes #246 (#277)
d41605e
roll pushed a commit that referenced this pull request Aug 14, 2020
@paulgirard
Fixed headers management for multiparts in tabular resource (#257)
ab08bd3 
* discarding header row of tabular multipart chunks
relates #256

* using streams correctly in python 3.x

* Remove first row in chunk only if != header\n see https://github.com/frictionlessdata/datapackage-py/pull/257#pullrequestreview-375804017\n and https://github.com/frictionlessdata/forum/issues/1

* bug in row iteration

* better warning message

* use iterator for streams in multipart fixes #246

* linter compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roll