Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example source name to fit stated requirements #418

Closed
wants to merge 1 commit into from
Closed

Update example source name to fit stated requirements #418

wants to merge 1 commit into from

Conversation

reidab
Copy link
Contributor

@reidab reidab commented May 11, 2017

name — An identifier string. Lower case characters with ., _, - and / are allowed.

@reidab
Update example source name to fit requirements
52848bc 
> `name` — An identifier string. Lower case characters with `.`, `_`, `-` and `/` are allowed.
@rufuspollock
Copy link
Contributor

You are correct re this being out of line with the specs. Ironically, on this occasion what you have identified is a small bug in the specs so I'm closing this PR as wontfix and we'll fix the specs 😄 - please keep these corrections coming 👍

rufuspollock added a commit that referenced this pull request May 18, 2017
@rufuspollock
[#418,dp][m]: make dp spec to more readable style by largely revertin…
b9a22a2 
…g to pre v1-alpha (as at 4474b04).

Have tried to keep most of the substantive updates e.g.

* fields => properties
* tweaks in intro based on current version
* clarify that descriptor is JSON object and MAY be serialized as datapackage.json
* removed dataDependencies (done originally in 4a5919b) and schemas (we no longer have this as moved to Data Resource)
* standardize author and contributors to contributors and follow new defintion of contributors apart from `uri` part (use `web` instead)
* update license to licenses

TODO:

* profiles
* id field for DP: c080f69
rufuspollock added a commit that referenced this pull request May 18, 2017
@rufuspollock
[#418,#414,dr][l]: readability for Data Resource spec by reverting it…
717a80a 
… to resources section of DP spec pre v1-alpha (as at 4474b04).

Substantive changes from current head:

* `name` no longer MUST (reverted to SHOULD as per pre-v1-alpha)
  * I think this is better approach as it is not clear you always need a name. (Should prob have an issue about this).
* Data location can have `path` and `data` options as per old spec. This automatically fixes #414 "Reintroduce dedicated property for inline data on data resources".

TODO:

* Not quite sure about language: is Data Resource actually a container spec like DP or is it just a descriptor for resources within e.g. DP.
rufuspollock added a commit that referenced this pull request May 18, 2017
@rufuspollock
[#418,dp][s]: minor corrections to follow up previous big change.
fbda030 
* license -> licenses in example
* Add Specification heading and correct other heading levels
* tweak language in data resources section
rufuspollock added a commit that referenced this pull request May 18, 2017
@rufuspollock
[#418,jts,ux][s]: change Hash -> object throughout.
127c213
rufuspollock added a commit that referenced this pull request May 18, 2017
@rufuspollock
[#418,tdr][m]: readability for TDR spec by reworking it.
57abd8a 
* In part use pre v1-alpha or TDP spec (as at 4474b04).
* Change to data and path properties as per #414
* Refer to Data Resource spec rather than inline it again
* Rework file encoding and csv dialect sections
* Add JSON Tabular Data section to explain what data must look like
rufuspollock added a commit that referenced this pull request May 18, 2017
@rufuspollock
[#418,tdp][m]: simplify Tabular Data Package spec.
2df8f75 
* Revert intro and example to to pre v1-alpha (as at 4474b04).
* Reduce spec to referencing the two specs it builds on: Data Package and Tabular Data Resource
  * This differs from both pre v1-alpha (where we did not have TDR) and current version (current version re inlines most of Tabular Data Resource and Data Package)
rufuspollock added a commit that referenced this pull request May 18, 2017
@rufuspollock
[#418,csvddf][m]: refactor spec to be easier to read.
e6fe4b6 
* No substantive changes of any kind
* Break up intro with subheadings as per v1 alpha
* Have simple list of properties in a bulleted list that fits on a single page
rufuspollock added a commit that referenced this pull request May 19, 2017
@rufuspollock
[#418,dr,!][s]: change DR schema strings to be like data locators (UR…
89295ac 
…L or relative path).

This eliminate the last usage of JSON pointer in the spec and simplifies life for implementors.
rufuspollock added a commit that referenced this pull request May 19, 2017
@rufuspollock
[#418,dr][s]: one important additional restriction on relative resour…
42cc8c1 
…ce paths plus some minor language proofing.
rufuspollock added a commit that referenced this pull request May 21, 2017
@rufuspollock
[#418,csvddf][s]: allow delimiter to be multiple characters - fixes #340
0bbcb06 
 (again).
rufuspollock added a commit that referenced this pull request May 22, 2017
@rufuspollock
[#418,#309,dr,!][s]: make data resource name property required (and u…
551f868 
…nique) - fixes #309 (again).
rufuspollock added a commit that referenced this pull request May 22, 2017
@rufuspollock
[jts,#418,#314,!][s]: remove data package references from foreign key…
44e3ba1 
…s - fixes #314 (again).

* Moved data package references for foreign keys to patterns (still think this is useful).
rufuspollock added a commit that referenced this pull request May 22, 2017
@rufuspollock
[ts,#418,refactor][xs]: move field constraints section below types.
b44c593
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[ts,#418][s]: clarify constraints section (no substantive changes) --…
8ad2bd1 
… attempt to fix #296 (again).

* List constraints in table and pull out headings for type of constraint value and types that constraint can apply to
* Tidy up language and clarify that pattern test is applied pre-casting whilst e.g. min/max are post casting
* Removed (not clear what it meant): "The constraints listed above may also define a list of supported field types."
* Not absolutely sure what original fix for #296 was (since nothing firm concluded there vs pre v1 alpha ....)
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[dr,#418][xs]: remove mention of datapackage.json in data resource (r…
9edb16a 
…eintroduced mention accidentally in #418 work).
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[ts,#418,!][s]: remove g on gyear and gyearmonth (redo for #418 of e4…
e6dc008 
…619dd).
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[ts,#418,refactor][s]: more work on readability in field descriptors.
44c668e 
* Separate each property of field descriptor into own section
* Explain table level properties
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[ts,#418][s]: refactor to have a heading each for date, datetime and …
4659e97 
…time plus tweak duration entry.
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[dp,#418][s]: refactor to have headings for each metadata property.
7896568
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[profiles,#87,#418][m]: reintroduce profiles work from v1 alpha as se…
67fa3f9 
…parate mini-spec.

* /profiles/ is a mini-spec explaining and defining meaning and syntax of profile property
* [dr]: add profile property
* [dp]: add profile property
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[dp,#237,#418][s]: reintroduce id field on dp as part of #418 rework …
c7baa5e 
…(originally in 9b92ad5).
rufuspollock added a commit that referenced this pull request May 24, 2017
@rufuspollock
[dp,#418][m]: reintroduce created property from v1 alpha (7542275).
1577de8 
Note: a small tweak to wording vs v1 alpha (comment on semantics of created).
This was referenced May 24, 2017
Closed
Closed
Closed
@rufuspollock
Copy link
Contributor

rufuspollock commented May 24, 2017 •
edited
Loading

NB: i accidentally referenced this issue in a lot of commits rather than #420!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Open Knowledge
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reidab @rufuspollock