Restricting commentChar
to ignore a line only if it appears at the start
#662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion in issue #254, I've built upon #624 to simplify the behavior we're expecting. Otherwise, there are different interpretations of the behavior a
commentChar
could have and there is varied support is across different CSV parsers. The approach here sets a baseline for what a comment should do at minimum which we can later extend with additional attributes if need be.Is it worth bumping up the version number? In theory this breaks compatibility with the previous description of
commentChar
even though this updated definition is in line with the original motivation of adding this feature.