Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableSchema: backticks to code in table #668

Merged
merged 1 commit into from
Apr 30, 2020

Conversation

AntoineAugusti
Copy link
Contributor

@AntoineAugusti AntoineAugusti commented Apr 20, 2020

Backticks aren't parsed as Markdown here for some reasons, so I switched everything to the HTML version.

Prod URL: https://specs.frictionlessdata.io/table-schema/#constraints

image

@rufuspollock
Copy link
Contributor

@lauragift21 can you take a look at this - is this to do with how vuepress works that backticks aren't being processed?

@AntoineAugusti
Copy link
Contributor Author

It's a Markdown issue. If you look at the file in GitHub you'll see the issue as well

@lauragift21
Copy link
Contributor

@rufuspollock @AntoineAugusti I can take a look and figure out why it has this behavior. Normally it should be able to render as markdown.

@lauragift21
Copy link
Contributor

I think this is happening because we have the table rendered in HTML and using backticks inside the HTML syntax will render something like this / code / .

My proposed solution will be to either stick to using HTML syntax all through the table or switch the table to markdown format.

@AntoineAugusti
Copy link
Contributor Author

I chose to switch everything to HTML because almost everything was already in HTML

@rufuspollock
Copy link
Contributor

@AntoineAugusti thanks for this fix 🙏 😄 👍

@rufuspollock rufuspollock merged commit 7620571 into frictionlessdata:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants