Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CastTable reports all errors #89

Merged
merged 1 commit into from
Aug 31, 2020
Merged

CastTable reports all errors #89

merged 1 commit into from
Aug 31, 2020

Conversation

danielfireman
Copy link
Collaborator

@danielfireman danielfireman commented Aug 29, 2020 •
edited
Loading

Overview

CastTable reports all errors instead of only the first one.

Please preserve this line to notify @danielfireman (lead of this repository)

This change is Reviewable

@danielfireman danielfireman requested a review from Irio August 29, 2020 18:57
@danielfireman
Copy link
Collaborator Author

cc/ @joeberth

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 92.863% when pulling 51083a8 on castTable_errors into 1c5741f on master.

joeberth
joeberth approved these changes Aug 31, 2020
View reviewed changes
Copy link

@joeberth joeberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@danielfireman danielfireman merged commit 126e37f into master Aug 31, 2020
@danielfireman danielfireman deleted the castTable_errors branch August 31, 2020 21:04
@danielfireman danielfireman mentioned this pull request Aug 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeberth joeberth joeberth approved these changes

@Irio Irio Awaiting requested review from Irio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielfireman @coveralls @joeberth