Save a table schema descriptor to a file path

[georgeslabreche]

• Schema: Change method name from "write" to "save"
• Schema: Pretty print.
• Table: Change method name from "write" to "save"

[georgeslabreche]

@pwalsh: This has already been implemented here:

tableschema-java/src/main/java/io/frictionlessdata/tableschema/Schema.java

Lines 173 to 177 in 55c364e

	public void write(String outputFilePath) throws IOException{
	try (FileWriter file = new FileWriter(outputFilePath)) {
	file.write(this.getJson().toString());
	}
	}

Test case is here:

tableschema-java/src/test/java/io/frictionlessdata/tableschema/SchemaTest.java

Lines 207 to 242 in 55c364e

	@Test
	public void testWrite() throws Exception{
	File createdFile = folder.newFile("test_schema.json");
	Schema createdSchema = new Schema();
	Map<String, Object> intFieldConstraints = new HashMap();
	intFieldConstraints.put(Field.CONSTRAINT_KEY_REQUIRED, true);
	Field intField = new Field("id", Field.FIELD_TYPE_INTEGER, Field.FIELD_FORMAT_DEFAULT, null, null, intFieldConstraints);
	createdSchema.addField(intField);
	Map<String, Object> stringFieldConstraints = new HashMap();
	stringFieldConstraints.put(Field.CONSTRAINT_KEY_MIN_LENGTH, 36);
	stringFieldConstraints.put(Field.CONSTRAINT_KEY_MAX_LENGTH, 45);
	Field stringField = new Field("name", Field.FIELD_TYPE_STRING, Field.FIELD_FORMAT_DEFAULT, "the title", "the description", stringFieldConstraints);
	createdSchema.addField(stringField);
	createdSchema.write(createdFile.getAbsolutePath());
	Schema readSchema = new Schema(createdFile.getAbsolutePath());
	Assert.assertEquals(readSchema.getField("id").getType(), Field.FIELD_TYPE_INTEGER);
	Assert.assertEquals(readSchema.getField("id").getFormat(), Field.FIELD_FORMAT_DEFAULT);
	Assert.assertEquals(readSchema.getField("id").getTitle(), "");
	Assert.assertEquals(readSchema.getField("id").getDescription(), "");
	Assert.assertTrue((boolean)readSchema.getField("id").getConstraints().get(Field.CONSTRAINT_KEY_REQUIRED));
	Assert.assertEquals(readSchema.getField("name").getType(), Field.FIELD_TYPE_STRING);
	Assert.assertEquals(readSchema.getField("name").getFormat(), Field.FIELD_FORMAT_DEFAULT);
	Assert.assertEquals(readSchema.getField("name").getTitle(), "the title");
	Assert.assertEquals(readSchema.getField("name").getDescription(), "the description");
	Assert.assertEquals(36, readSchema.getField("name").getConstraints().get(Field.CONSTRAINT_KEY_MIN_LENGTH));
	Assert.assertEquals(45, readSchema.getField("name").getConstraints().get(Field.CONSTRAINT_KEY_MAX_LENGTH));
	}

Is it meant to be invokable from somewhere else?

[georgeslabreche]

Lack of prettyprint is probably problematic...

[roll]

@georgeslabreche
I've missed it because was searching for schema.save according to naming conventions - https://github.com/frictionlessdata/implementations#tableschema.

Could you rename it to save for consistency?

[georgeslabreche]

@roll you bet! What about prettyprint. Is it going to be a problem that it's not supported?

[roll]

@georgeslabreche
It's better to preserve readability because a common use case is:

• save descriptor to a file
• update the file manually
• load the file to continue the work