Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project being maintained or has it been abandoned? #244

Closed
alexpareto opened this issue Oct 9, 2018 · 28 comments
Closed

Is this project being maintained or has it been abandoned? #244

alexpareto opened this issue Oct 9, 2018 · 28 comments

Comments

@alexpareto
Copy link

No description provided.

@elliottsj
Copy link
Collaborator

elliottsj commented Oct 15, 2018

@fridays Would you be open to adding additional maintainers to this project?

For now, I am maintaining my own fork over at https://github.com/Yolk-HQ/next-routes / https://www.npmjs.com/package/@yolkai/next-routes. I don't like the idea of forcing whole the community to move to a fork though, so my intention is to keep this fork maintained until fridays/next-routes becomes maintained again, or @fridays can comment on the future of this package.

So far, I have addressed #181 in my fork. Please create issues / pull requests on my fork if you'd like them addressed.

@michaeljonathanblack
Copy link

Thanks for setting that up @elliottsj! I may be opening a PR against your fork shortly.

@maggo
Copy link

maggo commented Jan 10, 2019

Ping! Happy new year! 🎉

@fridays it would be nice if you added @elliottsj / the Yolk team as maintainers, they seem to be super active (Thank you!)

I'd love to use this project, but am concerned about a future upgrade to next v8

@usergenic
Copy link

gentle ping

@drewlustro
Copy link

also would like to know

@fridays
Copy link
Owner

fridays commented Feb 5, 2019

Hi everybody, sorry for the delay and thank you for your patience. I just added @elliottsj as maintainer to the project.

Currently I'm unable to find the time this project deserves. Please let me know if I should add more people or whatever I can do to make it easy for you. Thanks

@elliottsj
Copy link
Collaborator

Thanks @fridays! In the coming days, I'm planning on merging the improvements in my fork back upstream. There are a lot of open issues & PRs in this repo, so I won't be able to get to all of them, but I'll try my best.

@fridays Would you like to continue to be in charge of publishing new versions to npm? If you like, I can take care of that too; my npm username is elliottsj: https://www.npmjs.com/~elliottsj

@gabrieledarrigo
Copy link

gabrieledarrigo commented Feb 18, 2019

Ciao guys, so is this still maintained?

@abrkn
Copy link

abrkn commented Mar 7, 2019

@elliottsj Where is your fork?

@felixmosh
Copy link

@elliottsj, why you are not merging your changes to here?

@elliottsj
Copy link
Collaborator

Sorry folks, I've been busy with work & life things, and I haven't had the time to dedicate to this project recently. I've under-delivered on my last message, and I apologize for that.

The PR to merge back upstream is here, and the next steps are to fix the build, then merge, publish version 3.0.0, disable Greenkeeper, and enable Renovate, as long as @fridays has no objections.

I can't promise that I'll be able to take this on in the near future, so it would be appreciated if someone else can step up.

@felixmosh
Copy link

@elliottsj thanx for explaining

@ItsWendell
Copy link

Looking forward to seeing this updated again!

@mehmetnyarar
Copy link

I couldn’t make it work neither with this repo nor @yolkai. so i basically copied the src/index.js to my project, add typings, made some small modifications, and using it now w/o problem.

You can check this gist.

@elliottsj
Copy link
Collaborator

Dynamic routes are now natively supported by Next.js, so next-routes is no longer necessary for most use cases.

@emileber
Copy link

emileber commented Jul 8, 2019

next-routes is no longer necessary for the most simple use cases.

Emphasis mine.

next-routes should have been in Next from the beginning but it was not. Next.js leaves us empty handed when we need a little more configuration with routing when we have constraints out of our control, like not having a server to render on.

Unfortunately, the new dynamic routes are far from being enough to ditch next-routes.

@YYCoder
Copy link

YYCoder commented Jul 22, 2019

next-routes is no longer necessary for the most simple use cases.

next-routes should have been in Next from the beginning but it was not. Next.js leaves us empty handed when we need a little more configuration with routing when we have constraints out of our control, like not having a server to render on.

Unfortunately, the new dynamic routes are far from being enough to ditch next-routes.

I agree 😆. Personally, I prefer centralized routing declaration like next-routes to file path based routing.

@martpie
Copy link

martpie commented Jul 22, 2019

I agree next-routes is not going anywhere (regex check are too much of a powerful feature for example).

It is worth noticing that the server(less) middleware RFC will probably solve 90% of the problem next-routes solve.

@caribou-code
Copy link

caribou-code commented Jul 26, 2019

I agree that the new dynamic routing in NextJS 9 isn't sufficient for all cases. I'm building a bilingual site where the different locale versions of a URL need to point to the same file/path. That can't be done easily without something like next-routes.

Kind of depressing that this issue has been open for 9 months and there's still no commits in a year. This package has around 50k weekly npm downloads and growing.

@elliottsj
Copy link
Collaborator

I agree that next-routes is still useful for more complex use cases. Unfortunately neither @fridays nor myself have the resources to keep this project maintained at the moment, so a good way to get next-routes maintained again is for someone in the community who actively uses next-routes to volunteer to take over maintenance.

@caribou-code
Copy link

There's currently 30 PRs open on this project so it looks like there's no shortage of people willing to contribute and get involved. Many are from the same people. Might I suggest handing over control to one/some of them so some of the PRs and issues can make some progress?

@martpie
Copy link

martpie commented Aug 4, 2019

@yolkai/next-routes looks like the most active fork. We used it at work without encountering troubles.

https://www.npmjs.com/package/@yolkai/next-routes

@maggo
Copy link

maggo commented Aug 5, 2019

The fork you linked has been archived @martpie: https://github.com/yolk-hq/next-routes#readme

There used to be a PR to merge it back, but it was closed. What's the reasoning here @elliottsj? Maybe this could be merged to make it easier for a future maintainer?

Sadly I don't have an active next project right now and also lost track over what's in core and what needs to be solved with third-party libraries, so I won't be able to maintain it properly. I hope to get back into it soon :)

@Timer
Copy link
Collaborator

Timer commented Dec 10, 2019

Hey, Next.js Core Team member here! We'd be interested in taking over maintenance of this package if you'd be willing to grant myself access to the repo and npm.

@fridays
Copy link
Owner

fridays commented Dec 11, 2019

Hi, that's great news! I just added you to the repo and npm.

@janbiasi
Copy link

@Timer any updates available 😄 ?

@raybaann
Copy link

Looking forward to the updates.

@fabn
Copy link

fabn commented Aug 12, 2020

@Timer any news? Is this something is still worth to invest?

@fridays fridays closed this as completed Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests