Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into an issue adding query strings to Next routes. For example, when viewing a "reviews" page like so -
/someurl/:slug/reviews
we need to paginate with a query string like -/someurl/my-slug/reviews?page=1
This works fine if you push a shallow route with
Link
however, on SSR reloads, only the named param segments are added to theprops.url.query
for the page. This fixes this by mergingparams
and thequery
with named params taking precedence